Fix QTMProtocol.event_future leak on await_event timeout#60
Open
ulvs wants to merge 1 commit into
Open
Conversation
asyncio.wait_for cancels _wait_loop on timeout but the queued event_future stays referenced. The next await_event call then sees event_future is not None and raises "Can't wait on multiple events!" even though no event is actually being awaited. Wrap the wait_for in try/finally and clear event_future on the way out. On success _on_event already cleared it; assignment is a no-op. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.wait_forcancels_wait_loopon timeout butevent_futurestays set. The nextawait_eventcall then sees it and raisesCan't wait on multiple events!even though nothing is being awaited.Wraps
wait_forintry/finallyand clearsevent_futureon the way out. On success_on_eventalready cleared it; the assignment is a no-op.Adds a
test_await_event_after_timeoutregression test.