Skip to content

QUD-1808: Reverting dev description writing to registery #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5656hcx merged 1 commit into from
Mar 19, 2026
+7 −34
Merged

QUD-1808: Reverting dev description writing to registery #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/windows/wdfserial/QCMAIN.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ WDF_DECLARE_CONTEXT_TYPE_WITH_NAME(REQUEST_CONTEXT, QCReqGetContext)
#define VEN_DEV_ZLP_ON L"QCDeviceZLPEnabled"
#define VEN_DEV_CID L"QCDeviceCID"
#define VEN_DEV_SOCVER L"QCDeviceSOCVER"
#define VEN_DEV_DESC L"QCDeviceDescription"

//DBG Macros
#define VEN_DRV_RESIDENT L"QCDriverResident"
Expand Down
40 changes: 7 additions & 33 deletions src/windows/wdfserial/QCPNP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,39 +1436,13 @@ NTSTATUS QCPNP_EvtDevicePrepareHardware
0x0409
);

if (!NT_SUCCESS(status))
{
QCSER_DbgPrint
(
QCSER_DBG_MASK_CONTROL,
QCSER_DBG_LEVEL_ERROR,
("<%ws> QCPNP_EvtDevicePrepareHardware: USB ProductInfo query FAILED: 0x%x\n", pDevContext->PortName, status)
);
ExFreePoolWithTag(buffer, '2gaT');
// Continue with device initialization despite this failure
}
else
{
buffer[strLen] = L'\0';
status = QCMAIN_SetDriverRegistryStringW(VEN_DEV_DESC, buffer, pDevContext);
if (!NT_SUCCESS(status))
{
QCSER_DbgPrint
(
QCSER_DBG_MASK_CONTROL,
(QCSER_DBG_LEVEL_ERROR),
("<%ws> QCPNP_EvtDevicePrepareHardware: USB ProductInfo: set FAILED: 0x%x\n", pDevContext->PortName, status)
);
}
else {
QCSER_DbgPrint
(
QCSER_DBG_MASK_CONTROL,
QCSER_DBG_LEVEL_DETAIL,
("<%ws> QCPNP_EvtDevicePrepareHardware USB ProductInfo: %ws, status: 0x%x, strlen: %llu\n", pDevContext->PortName, buffer, status, strLen)
);
}
}
buffer[strLen] = L'\0';
QCSER_DbgPrint
(
QCSER_DBG_MASK_CONTROL,
QCSER_DBG_LEVEL_DETAIL,
("<%ws> QCPNP_EvtDevicePrepareHardware USB ProductInfo: %ws, status: 0x%x, strlen: %llu\n", pDevContext->PortName, buffer, status, strLen)
);
ExFreePoolWithTag(buffer, '2gaT');
} // End printing usb device info as debug message
}
Expand Down
Loading