Title : Improved line length check in commit message.#30
Merged
Conversation
ynancher
reviewed
May 13, 2026
Contributor
|
I see test cases are failing because of incorrect formatting. Please check. |
snainani
force-pushed
the
snainani_develop
branch
from
1ed7bfc to
31b1333
Compare
ynancher
approved these changes
May 14, 2026
Enhanced validation logic for commit message line length. Allow long words such as URLs or identifiers without spaces. If the last word starts after the 72 character limit It reports an error.Otherwise allow lines where a single word extends beyond the limit. Signed-off-by: Sumit Nainani <snainani@qti.qualcomm.com>
snainani
force-pushed
the
snainani_develop
branch
from
4bd4a6b to
d84ded9
Compare
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the logic of checking line length check of commit body which can allow words without spaces like urls etc.The new logic will check if the last space of a line is occuring beyond the body character limit then it should throw the error.