fix(gstreamer): harden log validation for successful decode pipelines#398
Merged
bhargav0610 merged 1 commit intoqualcomm-linux:mainfrom Apr 9, 2026
Merged
fix(gstreamer): harden log validation for successful decode pipelines#398bhargav0610 merged 1 commit intoqualcomm-linux:mainfrom
bhargav0610 merged 1 commit intoqualcomm-linux:mainfrom
Conversation
…lines Improve GStreamer log validation so successful decode pipelines are not marked as failed due to benign downstream CRITICAL warnings. What this fixes: - ignore known non-fatal V4L2 decode warnings seen on successful H.264, H.265, and VP9 decode paths - keep hard failures for real ERROR/FATAL, negotiation, state-change, and resource issues - use pipeline success evidence such as PLAYING, caps negotiation, and EOS completion before treating remaining CRITICAL messages as fatal Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #397 the GStreamer log validation helpers to avoid false failures on successful decode pipelines that emit benign downstream CRITICAL warnings.
What changed:
Why:
Video decode pipelines were completing successfully with exit code 0, caps negotiation, PLAYING state, and EOS, but the testcase was still marked as failed because the validator treated all CRITICAL log messages as fatal.
Impact: