Skip to content

Update qcom-preflight-checks.yml#75

Open
Sandhya1236 wants to merge 1 commit intoqualcomm-linux:mainfrom
Sandhya1236:Update-Qualcomm-Preflight-Checks-with-latest
Open

Update qcom-preflight-checks.yml#75
Sandhya1236 wants to merge 1 commit intoqualcomm-linux:mainfrom
Sandhya1236:Update-Qualcomm-Preflight-Checks-with-latest

Conversation

@Sandhya1236
Copy link
Copy Markdown

Running untrusted code on the pull_request_target trigger may lead to security vulnerabilities. These vulnerabilities include cache poisoning and granting unintended access to write privileges or secrets.

https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target

We should update all usage of pull_request_target in all workflow files and also update qualcomm-preflight-check to the latest.

@Sandhya1236 Sandhya1236 force-pushed the Update-Qualcomm-Preflight-Checks-with-latest branch from 5d2d6c3 to 93d21f6 Compare March 26, 2026 04:27
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pull_request

@njjetha
Copy link
Copy Markdown

njjetha commented Apr 1, 2026

@Sandhya1236 Please update the filename .github/dependabot.yml and use pull_request instead of pull_request_target.

@quic-kaushalk
Copy link
Copy Markdown
Collaborator

@njjetha , @Sandhya1236 : Let me know if this is finalized and change can be merged?

dependency-review: true # default: true
secrets:
SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
enable-semgrep-scan: true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is being checked by semgrep here?

secrets:
SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
enable-semgrep-scan: true
enable-dependency-review: true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of dependencies are being tracked for this repo?

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

pull_request_target can be a security vulnerability and should be avoided and also aligned with latest pre-flight check workflow.

Signed-off-by: Sandhya Adavikolanu <sadaviko@qti.qualcomm.com>
@Sandhya1236 Sandhya1236 force-pushed the Update-Qualcomm-Preflight-Checks-with-latest branch from 2cd236c to b6da033 Compare April 14, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants