RFC: Add layer to make images 'Axiom ready' #849
Conversation
koenkooi
requested review from
ndechesne,
quaresmajose,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
I think, the commit message (and likely a small README) should mention, what is Axiom. Otherwise LGTM.
Test jobs for commit 868c1a6 |
Test jobs for commit e68b2d5 |
koenkooi
force-pushed
the
koen/axiom-images
branch
from
e68b2d5 to
32a858a
Compare
Good point, I've added a placeholder README.md that I need to fill in some more. |
koenkooi
force-pushed
the
koen/axiom-images
branch
from
32a858a to
097b4a7
Compare
Test jobs for commit 32a858a |
Test jobs for commit 097b4a7 |
|
I like the layer separation but don't personally like having this layer here, since axiom is really internal to qualcomm, and no external user will ever use or have to care about it. While having it under another repository is a bit more work (due approvals and what not), that might look better in the end. Guess we can merge this now and get the required approvals to move it elsewhere. |
Adding and activating this layer will add support for Axiom to the images it has bbappends for. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
The goal of this class is to transparently add the missing dependencies for running the image in Axiom. Currently it is only adding adb, nmcli and all kernel modules. Co-developed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Make core-image-base inherit axiom-image to add the dependencies needed for running it inside Axiom. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Disable CONFIG_USB_MASS_STORAGE so that it doesn't have a chance to take over UDC before adbd starts. [ Adapted from meta-qcom layer commit ] Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
koenkooi
force-pushed
the
koen/axiom-images
branch
from
097b4a7 to
a1584f1
Compare
Test jobs for commit a1584f1 |
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
Fine to merge as is and migrate in parallel to a different repo. @ndechesne we basically need to decide where we want to land the axiom related changes, separated repo might work better, knowing we need the axiom stuff on builds from meta-qcom and from meta-qcom-distro.
|
sorry to join the discussion late, but that's because you did it during my vacation :) I am not much in favor of this PR unfortunately.. I don't know what led us to want to do it this way. I don't see anything here that cannot be done as a simple 'test image' in meta-qcom directly. Using a layer seems very expensive, and using a layer in its own repo even more. while adbd and nmcli needs came from internal discussions to generate an image for our internal axiom thingy, i don't think these features should be done in an 'axiom' layer. What's wrong with a test image that would enable adbd and nmcli? |
adbd and nmcli require meta-oe and meta-networking, so we can't enable it straight away |
|
Then back to my initial comment, why are we not adding that in meta-qcom-distro instead? |
There are some additional overrides associated with the changes that are not image specific (e.g. additional kernel config fragment). And while we could land in distro, in the end we want to test meta-qcom and meta-qcom-distro images on axiom. |
Being able to test meta-qcom without depending on meta-qcom-distro. |
Include packages and ptests available in OE Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Test jobs for commit 3ac2dc1 |
4 participants
This adds the 'meta-axiom-ci' layer as well as a KAS fragment to enable it:
kas build meta-qcom/ci/qcs6490-rb3gen2-core-kit.yml:meta-qcom/ci/distro.yml:meta-qcom/ci/axiom.ymlWill build core-image-base, with adb, nmcli and all kernel modules installed. Images can be 'converted' by adding a bbappend that inherits the
axiom-imagebbclass.A bbappend for
linux-yocto-devdisables USB mass storage support to make adb USB gadget activation more robust, additional bbappends might be needed for platforms that use a different kernel.