Enable support for IQ-8275-AC STARTER EVK board#1873
Conversation
| @@ -13,6 +13,7 @@ KERNEL_DEVICETREE ?= " \ | |||
|
|
|||
| # These DTs are not upstreamed and currently exist only in linux-qcom kernels | |||
| LINUX_QCOM_KERNEL_DEVICETREE ?= " \ | |||
| qcom/monaco-evk-ac-sku.dtb \ | |||
There was a problem hiding this comment.
Please wait for the name to be at least agreen upon upstream. Not to mention that your commit message doesn't explain, why do we want it, why is it different from the normal monaco-evk.dtb and why it's being enabled as a part of IQ-8275-EVK machine.
There was a problem hiding this comment.
Hello Dmitry,
Had raised this PR as draft PR just for validation and sharing with other teams for internal testing.
There was a problem hiding this comment.
Commit message is still not saying why you are adding this as part of monaco-evk (iq-8275-evk).
There was a problem hiding this comment.
Acknowledge, updated commit message.
nkumarsi
changed the title
nkumarsi
requested review from
anujm1,
koenkooi,
ndechesne,
ricardosalveti,
sbanerjeeqc and
vkraleti
as code owners
|
What is AC here? |
Hi @ricardosalveti , Here, ac refers to QCS8300-AC SKU, a variant of monaco SoC (QCS8300) with 20 TOPS NPU capability and a simplified two-PMIC power delivery network (2x PM8650AU), as opposed to the QCS8300-AA SKU used in the existing monaco-evk. |
Please add this to the commit message. |
Thank you for the review . updated the commit message. |
|
Please rebase. |
Done rebased it. |
|
The BT WA changes were not carried in the current promoted tag - and it's was missed to add it in the refactored change for monaco-evk and monaco-ac-evk - hence moving this PR to draft PR for now until proper clean changes are bought in ... The corresponding kernel promotion of the same also will be reverted ... |
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 5 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
|
Hi @ricardosalveti , could you please help review this PR? |
acknowledge , updated |
Acknowledged. |
What is the marketing name for the board? E.g. |
Marketing name for the monaco-ac board is the same as IQ-8275 EVK. |
How does one distinguish, which one is it buying or working with? Having the same marketing name for two different boards is a disaster. |
monaco-ac (2*PMIC) is only for licenced customers. Not for developers. |
What does this change? The customer writes to us about the problem with the IQ-8275 EVK. Which board does it concern? |
@lumag - I believe customers can know the board variant via CDT and/or DT model string as well - Just checking if a different marketing name would be needed? As this is intended only for licensed customers.... What are your thoughts on the same ? |
I already shared them: each board should have a unique name, |
@lumag Here Carrier board is EVK and EVK design and pin compatibility remain same for both the SKU and between 2XPMIC and 4XPMIC variant/SKU it is SoC Daughter card which is changing, and we have Marketing name only as per carrier board not as Per SoC's SKUs. |
|
Carrier board doesn't define the device. Again, which board is affected if the customer reports and error happening with the 'IQ-8275 EVK'? |
Marketing Team is not averse of using IQ-8275-AC EVK for 2XPMIC SKU. |
Then I think it should be settled this way. Please update the commit message. |
Hi @lumag , Marketing team suggested using IQ-8275-ac-starter-evk for RB4 2PMIC board. can we update commit text with same ? |
What is 'starter'? Also, why 'evk' is now lowercase and squashed to the name? |
Hi @lumag , we have two more new RB4 EVK variants in the pipeline (of both 4 PMIC and 2 PMIC variants). To clearly differentiate between them, the marketing team has suggested naming this 2 PMIC RB4 AC variant as mentioned above. With capitalization applied, can we name it IQ-8275-AC-STARTER-EVK? |
|
@umang-chheda what is so "starter" in it? What would be the name for the two other EVKs? |
@lumag - This version of RB4 - AC variant is an entry level developer hardware kit designed to minimize the cost and to help developer to get started with - hence the name "starter" in it. "starter" here is added - to differentiate b/w the advanced feature's EVK which might come in near future.
Currently the name of other two planned EVKs cannot be disclosed. |
|
Okay , thanks a lot for all the explanations! Could you please rebase on the current master and use the established name in the commit messages. |
nkumarsi
changed the title
Sure, thank you for the feedback. I’ve rebased and updated the commit message. |
| FIT_DTB_COMPATIBLE[qcom_qcs8275-iot] = \ | ||
| "monaco-evk monaco-evk-camera-imx577" | ||
|
|
||
| FIT_DTB_COMPATIBLE[qcom_qcs8275-iot-subtype0] = "monaco-ac-evk monaco-evk-camera-imx577" |
There was a problem hiding this comment.
Since you added the dtb to LINUX_QCOM_KERNEL_DEVICETREE, change https://github.com/qualcomm-linux/meta-qcom/blob/master/conf/machine/include/fit-dtb-compatible-linux-qcom.inc instead.
|
Change to |
Include monaco-ac-evk.dtb in LINUX_QCOM_KERNEL_DEVICETREE to support the IQ-8275-AC STARTER EVK. The IQ-8275-AC STARTER EVK is a hardware variant of the IQ-8275 (monaco) platform with a reduced PMIC configuration (2x PM8654AU), compared to the IQ-8275 EVK which uses a 4-PMIC setup (Monaco-AA SKU). Apart from this difference, the rest of the hardware peripherals are largely identical and shared across both variants. Since the IQ-8275-AC STARTER EVK belongs to the same platform family and reuses the same core hardware description, it is added to the machine IQ-8275. Add the corresponding FIT compatible mapping to distinguish the variant and ensure the correct DTB is selected during boot. Signed-off-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
Add compatible string mapping for monaco-ac-evk.dtb to ensure the correct DTB is selected during boot for the IQ-8275-AC STARTER EVK. Signed-off-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
Acknowledged. |
5 participants
Add IQ-8275-AC STARTER EVK support to the machine IQ-8275 and add the corresponding FIT compatible mapping.
The IQ-8275-AC STARTER is a hardware variant of the IQ-8275 (monaco) platform
with a reduced PMIC configuration (2x PM8654AU), compared to the
IQ-8275 EVK which uses a 4-PMIC setup. The rest of the hardware
peripherals are largely identical and shared across both variants.
Since the IQ-8275-AC STARTER EVK belongs to the same platform family and reuses
the same core hardware description, it is added under the existing IQ-8275 machine.
Changes:
Add monaco-ac EVK DTB to LINUX_QCOM_KERNEL_DEVICETREE to the IQ-8275 machine
Add FIT DTB compatible string for monaco-ac-evk.dtb to ensure the
correct DTB is selected during boot