packagegroup-iq-9075-evk: include qca-qca61x4-usb#1279
packagegroup-iq-9075-evk: include qca-qca61x4-usb#1279vkraleti merged 1 commit intoqualcomm-linux:masterfrom
Conversation
WeiDeng-weiden
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
Is the USB Bluetooth present on board or is it attached separately? |
Test run workflowTest jobs for commit eb81f2a39b4d7f6ccafbec185e1c00b1509e8b2e
|
We attached connectivity chip separately through M.2 interface. UART and USB HSP are two different chips and require different firmware. |
You have attached it, it's fine. Why are you implying those changes on everybody? Please extend your local build config instead of adding irrelevant firmware to the machine configuration. Closing now. |
|
Unless attached by default (as part of the EVK hardware package), it should really be a distro level decision. |
Hello Maintainer, thanks for your comments. WCN685x USB interface In the current .bb file, linux-firmware-qca-qca2066 provides the firmware required for WCN685x UART. However, additional firmware is needed for other interfaces. For example, my change adds linux-firmware-qca-qca61x4-usb, which is required for WCN685x USB. Therefore, I believe we should also include the firmware required for the other attached interface chips. |
This needs to be explained in the commit message. Also please add WiFi and BT firmware for all these options. |
Test run workflowTest jobs for commit eb81f2a39b4d7f6ccafbec185e1c00b1509e8b2e
|
Thanks, will update commit message and re-submit. |
WeiDeng-weiden
force-pushed
the
package
branch
from
eb81f2a to
0afcfa5
Compare
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Please wrap commit message on a reasonable boundary (usually 72-75 chars).
Other than that:
s/wlan/WiFi/
s/bt/BT/
s/uart/UART/
"other interfaces" - what does that mean? Which interfaces? Other than M.2?
"This change include" - rewrite to use imperative language.
"- linux-firmware-ath12k-wcn7850 for including wcn7850 wlan fw." - package contents is obvious. Describe why we need the package. I'd rather describe per card (name, SKU, whatever) which firmware packages it needs.
Thanks for your suggestion. Will correct commit message. |
Test run workflowTest jobs for commit 0afcfa53ff84b6a62fda7d1cfb4f410fe7d3de53
|
WeiDeng-weiden
force-pushed
the
package
branch
from
0afcfa5 to
88966bf
Compare
Test run workflowTest jobs for commit 88966bf30fdb5940f66210aa7c27ea720b080c8e
|
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
- linux-firmware-ath12k-wcn7850:
WiFi firmware for WCN7850.
Other way around: a card name => firmware packages that are necessary for it.
Okay, I will make updates according to your suggestion. |
The IQ-9075-EVK platform does not have an on-board connectivity card. Per PDM requirements it is designed to support WCN685x and WCN7850 connectivity modules over the M.2 interface and therefore needs the corresponding WiFi and BT firmware. Add the required firmware packages for the supported modules: WCN685x connectivity module requires: - linux-firmware-qca-wcn685x (BT UART firmware) - linux-firmware-qca-qca61x4-usb (BT USB firmware) WCN7850 connectivity module requires: - linux-firmware-ath12k-wcn7850 (WiFi firmware) - linux-firmware-qca-wcn7850 (BT UART firmware) - linux-firmware-qca-qca61x4-usb (BT USB firmware) Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
WeiDeng-weiden
force-pushed
the
package
branch
from
88966bf to
91f6fb7
Compare
Test run workflowTest jobs for commit 91f6fb7
|
4 participants
This firmware is required for setting up BT with HSP USB interface on the iq-9075-evk platform. Therefore add linux-firmware-qca-qca61x4-usb.