Skip to content

QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC#1302

Open
jpagadal wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
jpagadal:tech/all/config
Open

QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC#1302
jpagadal wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
jpagadal:tech/all/config

Conversation

@jpagadal
Copy link
Copy Markdown

@jpagadal jpagadal commented Jun 3, 2026

Enable CONFIG_SWIOTLB_DYNAMIC to reduce static SWIOTLB memory reservation by allowing the bounce buffer pool to grow dynamically based on runtime DMA requirements.

Limit the swiotlb memory reservation to 2MB from 64MB - by setting swiotlb=128 kernel command line arg.
Enabling CONFIG_SWIOTLB_DYNAMIC to support PR - qualcomm-linux/meta-qcom#2302

CRs-Fixed: 4490764

@qcomlnxci qcomlnxci requested review from a team, sgaud-quic, shashim-quic and yijiyang and removed request for a team June 3, 2026 12:58
@qlijarvis
Copy link
Copy Markdown

PR #1302 — validate-patch

PR: #1302

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Analysis:
This is a vendor-specific configuration change for Qualcomm's kernel tree. The patch enables CONFIG_SWIOTLB_DYNAMIC, which allows the SWIOTLB bounce buffer pool to grow dynamically at runtime rather than reserving a large static pool at boot. This is a reasonable optimization for systems with varying DMA requirements.

The technical change is sound:

  • The config option is added in the correct alphabetical position (between CONFIG_SENSORS_QCOM_BCL and CONFIG_TRACE_MMIO_ACCESS)
  • The rationale is clear and valid
  • The change is minimal and focused

The only style issue is the redundant repetition of the subject line in the commit body, which is not standard kernel practice. However, this is a minor formatting concern and does not affect the correctness or safety of the change.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1302 - QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
Upstream commit: N/A (vendor-only config change)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit with QCLINUX: prefix
Body preserves rationale Clear explanation of why CONFIG_SWIOTLB_DYNAMIC is enabled
Fixes tag present/correct N/A Not a bug fix
Authorship preserved Jagadeesh Pagadala jpagadal@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/qcom.config Single config option added in alphabetically sorted position

Issues

  • Commit message duplication: The subject line is repeated verbatim as the first line of the commit body. This is redundant and violates kernel commit message style. The body should start directly with the rationale.
  • Minor style: While the change itself is correct, the duplicate subject line should be removed from the body.

Verdict

Acceptable for merge with minor commit message style issue (duplicate subject in body); functionality is correct.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Analysis:
This is a vendor-specific configuration change for Qualcomm's kernel tree. The patch enables CONFIG_SWIOTLB_DYNAMIC, which allows the SWIOTLB bounce buffer pool to grow dynamically at runtime rather than reserving a large static pool at boot. This is a reasonable optimization for systems with varying DMA requirements.

The technical change is sound:

  • The config option is added in the correct alphabetical position (between CONFIG_SENSORS_QCOM_BCL and CONFIG_TRACE_MMIO_ACCESS)
  • The rationale is clear and valid
  • The change is minimal and focused

The only style issue is the redundant repetition of the subject line in the commit body, which is not standard kernel practice. However, this is a minor formatting concern and does not affect the correctness or safety of the change.

@qlijarvis
Copy link
Copy Markdown

PR #1302 — checker-log-analyzer

PR: #1302
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26886281548

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - config-only change
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Missing required subject prefix
tag-check N/A Not applicable for config changes
qcom-next-check ⚠️ QCLINUX: prefix used (internal change)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1302 - QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26886281548

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - config-only change
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Missing required subject prefix
tag-check N/A Not applicable for config changes
qcom-next-check ⚠️ QCLINUX: prefix used (internal change)

❌ check-patch-compliance

Root cause: Commit subject uses "QCLINUX:" prefix which is not recognized by the patch compliance checker.

Failure details:

2026-06-03T13:16:30.4418442Z Commit summary does not start with a required prefix
2026-06-03T13:16:30.4471859Z Checking commit: QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
2026-06-03T13:16:30.4488210Z Commit summary does not start with a required prefix

Analysis:
The check-patch-compliance checker validates that commit subjects start with approved prefixes (typically UPSTREAM:, FROMLIST:, BACKPORT:, etc.) to indicate the patch's origin. This PR contains two commits:

  1. c8f71c6be43c - "QCLINUX: arm64: configs: enable USB configfs UVC and UAC2 functions"
  2. c98354855084 - "QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC"

Both use the QCLINUX: prefix, which indicates these are Qualcomm-internal configuration changes rather than upstream patches. The checker does not recognize this prefix.

Fix options:

Option 1: Update commit prefix (if this is an upstream patch)
If this config option is being enabled based on an upstream commit, use:

UPSTREAM: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC

Option 2: Configure checker to accept QCLINUX: prefix
If QCLINUX: is a valid prefix for internal config changes, the check-patch-compliance.sh script needs to be updated to accept it. This would require modifying the kernel-checkers repository to add QCLINUX to the list of allowed prefixes.

Option 3: Skip compliance check for config-only changes
Since this is a pure configuration change (no code modifications), the compliance check could be configured to skip config-only commits.

Reproduce locally:

cd /path/to/kernel-topics
git log --oneline -2 HEAD
# Check if commits have approved prefixes
git log -1 --format=%s HEAD | grep -E '^(UPSTREAM|FROMLIST|BACKPORT|QCLINUX):'

Verdict

1 blocker to fix: The commit subject prefix needs to be updated to use an approved prefix (UPSTREAM:, FROMLIST:, etc.) or the checker configuration needs to be updated to accept QCLINUX: as a valid prefix for internal Qualcomm configuration changes. All other checkers passed or were correctly skipped.

Recommendation: If this is a Qualcomm-internal config change (not from upstream), the most appropriate fix is to update the checker configuration to accept QCLINUX: as a valid prefix for config changes in the arch/arm64/configs/qcom*.config files.

Enable CONFIG_SWIOTLB_DYNAMIC to reduce static SWIOTLB memory reservation
by allowing the bounce buffer pool to grow dynamically based on runtime
DMA requirements.

Signed-off-by: Jagadeesh Pagadala <jpagadal@qti.qualcomm.com>
@qcomlnxci qcomlnxci requested a review from a team June 3, 2026 13:38
@qlijarvis
Copy link
Copy Markdown

PR #1302 — validate-patch

PR: #1302

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Analysis:

  • This is a vendor-only configuration change for Qualcomm's kernel tree
  • The commit enables CONFIG_SWIOTLB_DYNAMIC, which allows the SWIOTLB bounce buffer pool to grow dynamically instead of using static reservation
  • The rationale is clear: reduce static memory reservation and allow runtime-based allocation
  • The config option is added in the correct alphabetical position (between CONFIG_SENSORS_QCOM_BCL and CONFIG_TRACE_MMIO_ACCESS)
  • Proper sign-off is present from the author
  • The QCLINUX: prefix correctly identifies this as a vendor-specific change
  • No upstream validation is required for vendor config changes
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1302 - QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
Upstream commit: N/A (vendor-only config change)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit with QCLINUX: prefix
Body preserves rationale Clear explanation of why CONFIG_SWIOTLB_DYNAMIC is enabled
Fixes tag present/correct N/A Not a bug fix; feature enablement
Authorship preserved Proper author and sign-off present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/qcom.config Single config option added in alphabetically correct position

Verdict

Merge as-is — well-formed vendor config change with clear rationale.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Analysis:

  • This is a vendor-only configuration change for Qualcomm's kernel tree
  • The commit enables CONFIG_SWIOTLB_DYNAMIC, which allows the SWIOTLB bounce buffer pool to grow dynamically instead of using static reservation
  • The rationale is clear: reduce static memory reservation and allow runtime-based allocation
  • The config option is added in the correct alphabetical position (between CONFIG_SENSORS_QCOM_BCL and CONFIG_TRACE_MMIO_ACCESS)
  • Proper sign-off is present from the author
  • The QCLINUX: prefix correctly identifies this as a vendor-specific change
  • No upstream validation is required for vendor config changes

@qlijarvis
Copy link
Copy Markdown

PR #1302 — checker-log-analyzer

PR: #1302
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26888505056

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - no source code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance FAILED - Missing required prefix
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1302 - QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26888505056

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - no source code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance FAILED - Missing required prefix
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

❌ check-patch-compliance

Root cause: Commit subject uses QCLINUX: prefix, which is only allowed in qcom-next/qcom-next-staging branches. Topic branches require UPSTREAM:, FROMLIST:, or BACKPORT: prefixes.

Failure details:

2026-06-03T13:56:54.0252663Z Checking commit: QCLINUX: arm64: configs: enable USB configfs UVC and UAC2 functions
2026-06-03T13:56:54.0270133Z Commit summary does not start with a required prefix
2026-06-03T13:56:54.0324354Z Checking commit: QCLINUX: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
2026-06-03T13:56:54.0341253Z Commit summary does not start with a required prefix

Both commits in this PR fail the compliance check because they use the QCLINUX: prefix instead of the required upstream-tracking prefixes.

Fix: Update the commit subject to use one of the following prefixes based on the patch origin:

  1. If this config change is already merged upstream (mainline or stable):

    UPSTREAM: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
    

    Add a Link: tag pointing to the upstream commit in lore.kernel.org or git.kernel.org.

  2. If this config change is posted to a mailing list but not yet merged:

    FROMLIST: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
    

    Add a Link: tag pointing to the lore.kernel.org patch submission.

  3. If this is a backport of an upstream commit with modifications:

    BACKPORT: arm64: configs: qcom.config: Enable CONFIG_SWIOTLB_DYNAMIC
    

    Add a Link: tag to the original upstream commit and explain the backport changes.

  4. If this is a Qualcomm-specific change not intended for upstream:
    This patch should target the qcom-next or qcom-next-staging branch directly, where QCLINUX: prefix is allowed.

Reproduce locally:

cd /path/to/kernel-topics
git log --oneline -2 HEAD
# Check if subjects start with UPSTREAM:/FROMLIST:/BACKPORT:

Or use the checker script directly:

git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel-topics \
  --base <base-sha> --head <pr-head-sha>

Verdict

1 blocker to fix: The commit subject prefix must be changed from QCLINUX: to UPSTREAM:, FROMLIST:, or BACKPORT: depending on the patch's upstream status. This is a metadata-only fix that requires amending the commit message and force-pushing to the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants