QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor

[mmitkovquicinc]

Adds deserializer and camera sensor nodes to the Talos device tree. Talos features a single GMSL deserializer and exposes a single GMSL camera.

CRs-Fixed: 4555961

[qlijarvis]

PR #1291 — validate-patch

PR: #1291

Verdict	Issues	Detailed Report
N/A	0	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1291 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ SKIP (validation not applicable)

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: prefix indicates vendor-only commit
Body preserves rationale	N/A	No upstream source to compare against
Fixes tag present/correct	N/A	No Fixes tag; vendor-only addition
Authorship preserved	N/A	Original vendor contribution
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi	⏭️ SKIP	Vendor-only device tree additions (GMSL deserializer and sensor nodes)

Verdict

This is a vendor-only commit (QCLINUX: prefix) adding Talos-specific camera hardware nodes. No upstream validation is applicable or required. The commit is properly formatted for vendor-only changes with appropriate sign-off and internal CR tracking.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

[qlijarvis]

PR #1291 — checker-log-analyzer

PR: #1291
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26756170574

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 warnings: undocumented DT compatible, missing commit descriptions
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Graph port errors in new GMSL deserializer node
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	All 5 commits missing required prefix
tag-check	❌	All 5 commits missing required prefix (target branch: tech/overlay/dt)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1291 — QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26756170574

Checker	Result	Summary
checkpatch	❌	3 warnings: undocumented DT compatible, missing commit descriptions
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Graph port errors in new GMSL deserializer node
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	All 5 commits missing required prefix
tag-check	❌	All 5 commits missing required prefix (target branch: tech/overlay/dt)

---

❌ checkpatch

Root cause: Three commits have style issues: one undocumented DT compatible string and two commits with missing commit descriptions.

Failure details:

Commit abc71de7617a ("QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor"):

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#69: FILE: arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:188:
+		compatible = "qcom,cam-gmsl-sensor";

Commit b7de1d752e12 ("QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port..."):

WARNING: Missing commit description - Add an appropriate one

Commit fc647a8ed68a ("QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic..."):

WARNING: Missing commit description - Add an appropriate one

Fix:

1. For undocumented compatible string — Add binding documentation:

   # Create Documentation/devicetree/bindings/media/qcom,cam-gmsl-sensor.yaml
   # or add "qcom,cam-gmsl-sensor" to an existing camera sensor binding

2. For missing commit descriptions — The commit subjects are too long and contain the description. Move the description to the commit body:

   git rebase -i <base_sha>   # mark commits as 'edit'
   # For b7de1d752e12:
   git commit --amend
   # Change subject to: "QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port"
   # Move rest to body: "In order to enable combo mode on CSI1 mode, resources needs..."
   
   # For fc647a8ed68a:
   git commit --amend
   # Change subject to: "QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic"
   # Move rest to body: "Prevent GPIOs managed by pinctrl from being requested..."
   
   git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git df3ae9703774..2d37d93c0a70

---

❌ dtb-check

Root cause: The new port@0 node in qcom,cam-gmsl-deserializer0 is missing required #address-cells and #size-cells properties for graph port nodes, causing reg_format, avoid_default_addr_size, and graph_port warnings.

Failure details:

arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:178:4:

Warning (reg_format): /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:reg: 
  property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)

Warning (avoid_default_addr_size): ...port@0: Relying on default #address-cells value
Warning (avoid_default_addr_size): ...port@0: Relying on default #size-cells value

Warning (graph_port): ...port@0: graph node '#address-cells' is -1, must be 1
Warning (graph_port): ...port@0: graph node '#size-cells' is -1, must be 0

Fix:

Add explicit #address-cells and #size-cells to the port@0 node in arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:177:

 	/* GMSL deserializer 0 - max9296a */
 	qcom,cam-gmsl-deserializer0 {
 		cell-index = <2>;
 		...
 		status = "ok";
 
+		#address-cells = <1>;
+		#size-cells = <0>;
+
 		port@0 {
 			reg = <0>;
 			deser0_port0: endpoint {
 				remote-endpoint = <&gmsl_sensor0_ep>;
 			};
 		};
 	};

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/talos-evk-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb

---

❌ check-patch-compliance

Root cause: All 5 commits use the QCLINUX: prefix, which is not in the allowed list for check-patch-compliance. The checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT:.

Failure details:

Checking commit: arm64: dts: qcom: hamoa: add CAMX EL2 overlay
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port...
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic...
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Commit summary does not start with a required prefix

Fix:

This is a known limitation of check-patch-compliance — it does not accept vendor-only prefixes like QCLINUX: or PENDING:. These commits are vendor-specific DTS additions with no upstream equivalent.

Options:

1. If these patches have been posted upstream → change prefix to FROMLIST: and add Link: <lore-url> to commit body.
2. If vendor-only → this checker will always fail. The QCLINUX: prefix is correct for vendor-only changes, but check-patch-compliance enforces upstream-linkable prefixes only.

Note: The first commit (arm64: dts: qcom: hamoa: add CAMX EL2 overlay) is missing any prefix — add QCLINUX: to the subject.

---

❌ tag-check

Root cause: The PR targets branch tech/overlay/dt, which is not qcom-next or qcom-next-staging. All commits merged into this branch must start with a valid prefix tag. Five commits are missing or using invalid prefixes.

Failure details:

1. Commit a7c58823f27f ("arm64: dts: qcom: hamoa: add CAMX EL2 overlay") — no prefix
2. Commit 8d6e4e962e7e ("QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay") — QCLINUX: is valid ✅
3. Commit b7de1d752e12 ("QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port...") — QCLINUX: is valid ✅
4. Commit fc647a8ed68a ("QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic...") — QCLINUX: is valid ✅
5. Commit abc71de7617a ("QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor") — QCLINUX: is valid ✅

Fix:

Add QCLINUX: prefix to the first commit:

git rebase -i <base_sha>   # mark commit a7c58823f27f as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: hamoa: add CAMX EL2 overlay"
git rebase --continue

Valid prefixes for tech/overlay/dt branch:

• FROMLIST: — Posted to mailing list
• FROMGIT: — In a maintainer tree
• UPSTREAM: — Merged into Linus's tree
• BACKPORT: — Backported with modifications
• QCLINUX: — Vendor-only, no upstream
• PENDING: — Work-in-progress
• WORKAROUND: — Temporary fix

---

Verdict

Fix 4 blockers before merge:

1. ❌ checkpatch — Add DT binding for qcom,cam-gmsl-sensor and fix commit descriptions (move long subjects to body)
2. ❌ dtb-check — Add #address-cells = <1>; #size-cells = <0>; to qcom,cam-gmsl-deserializer0 node
3. ⚠️ check-patch-compliance — Known limitation for QCLINUX: prefix; will always fail for vendor-only commits
4. ❌ tag-check — Add QCLINUX: prefix to first commit (arm64: dts: qcom: hamoa: add CAMX EL2 overlay)