QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path

[cjha01]

Update the path for the camera icp firmware.

[qlijarvis]

PR #1290 — validate-patch

PR: #1290

Verdict	Issues	Detailed Report
N/A	0	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Note: The validate-patch skill is designed for commits that reference upstream lore.kernel.org patches (UPSTREAM:, BACKPORT:, FROMLIST:, FROMGIT: prefixes). Vendor-only commits with QCLINUX:, PENDING:, or WORKAROUND: prefixes do not require upstream validation as they are internal changes specific to the Qualcomm vendor tree.

Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1290 - QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ SKIP (validation not applicable)

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	N/A	No upstream source to compare
Fixes tag present/correct	N/A	Not applicable for vendor change
Authorship preserved	N/A	Original vendor commit
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/purwa-camera.dtsi	⏭️	Vendor-specific DTS change; no upstream comparison available

Verdict

This is a vendor-only commit (QCLINUX: prefix) that updates a camera firmware path in a Qualcomm device tree file. No upstream validation is applicable or required. The change is straightforward: updating the firmware path from qcom/x1p4x100/CAMERA_ICP to qcom/x1p42100/CAMERA_ICP.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Note: The validate-patch skill is designed for commits that reference upstream lore.kernel.org patches (UPSTREAM:, BACKPORT:, FROMLIST:, FROMGIT: prefixes). Vendor-only commits with QCLINUX:, PENDING:, or WORKAROUND: prefixes do not require upstream validation as they are internal changes specific to the Qualcomm vendor tree.

[qlijarvis]

PR #1290 — checker-log-analyzer

PR: #1290
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26752359265

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 commits missing commit descriptions
dt-binding-check	⏭️	No binding changes
dtb-check	❌	Pre-existing tree issues + new camera overlay errors
sparse-check	⏭️	No C/H changes
check-uapi-headers	⏭️	No C/H changes
check-patch-compliance	❌	All 5 commits fail prefix check (QCLINUX: not accepted)
tag-check	✅	All commits have valid prefixes (QCLINUX: is allowed)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1290 - QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26752359265
Target branch: tech/overlay/dt

Checker	Result	Summary
checkpatch	❌	2 commits missing commit descriptions
dt-binding-check	⏭️	No binding changes
dtb-check	❌	Pre-existing tree issues + new camera overlay errors
sparse-check	⏭️	No C/H changes
check-uapi-headers	⏭️	No C/H changes
check-patch-compliance	❌	All 5 commits fail prefix check (QCLINUX: not accepted)
tag-check	✅	All commits have valid prefixes (QCLINUX: is allowed)

---

❌ checkpatch

Root cause: Two commits have missing commit descriptions (subject line contains the full description instead of being in the commit body).

Failure details:

Commit b7de1d752e12 ("QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port In order to enable combo mode on CSI1 mode, resources needs to be in shared mode. This change adds required resources under res-mgr node.")
WARNING: Missing commit description - Add an appropriate one

Commit fc647a8ed68a ("QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic Prevent GPIOs managed by pinctrl from being requested and freed via the GPIO framework. Restrict GPIO request/free operations to non-pinctrl GPIOs by adding appropriate conditions.")
WARNING: Missing commit description - Add an appropriate one

Fix: Move the description text from the subject line to the commit body. The subject should be a single concise line (≤75 chars), with the detailed explanation in the body.

For commit b7de1d7:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend
# Change subject to: "QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port"
# Move the rest to body:
# 
# In order to enable combo mode on CSI1 mode, resources needs to be in
# shared mode. This change adds required resources under res-mgr node.
git rebase --continue

Repeat for commit fc647a8.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git df3ae9703774..ab576cb5c8ee

---

❌ dtb-check

Root cause: Multiple DTB validation errors — mix of pre-existing tree issues and new errors introduced by camera overlay additions.

Failure details:

Pre-existing tree issues (not caused by this PR):

• monaco.dtsi:7430 — usb-typec@47 interrupt cells mismatch (recurring issue)
• qcs6490-rb3gen2-industrial-mezzanine.dtso — multiple reg_format and avoid_default_addr_size warnings
• kodiak.dtsi, sm8750.dtsi — graph endpoint bidirectional connection warnings

New errors introduced by this PR:

• hamoa-camera.dtsi — 28+ reg_format warnings: reg property has invalid length (16 or 32 bytes) when #address-cells == 2, #size-cells == 1 expects 12 bytes
• hamoa-camera.dtsi — 28+ avoid_default_addr_size warnings: camera nodes rely on default #address-cells/#size-cells values
• purwa-camx-el2.dtb — Multiple schema validation failures:
  • qcom,cam-smmu, qcom,cci0@ac15000, qcom,cci1@ac16000 missing required properties: #address-cells, #size-cells, ranges
  • Multiple camera nodes (qcom,cam-req-mgr, qcom,cam-jpeg, qcom,cam-isp, etc.) failed to match any schema
  • pinctrl@f100000 unevaluated camera pinctrl properties (22 unexpected properties)

Fix:

1. For hamoa-camera.dtsi and purwa-camx-el2 camera overlays:

   • Add explicit #address-cells = <1>; #size-cells = <0>; to all camera bus nodes (qcom,cam-smmu, qcom,cci0, qcom,cci1, etc.)
   • Fix reg properties to match the declared cell sizes (single cell for address when #address-cells = <1>)
   • Add ranges; property to bus nodes that declare child address spaces

2. For missing schema errors:

   • These camera-specific compatible strings (qcom,cam-req-mgr, qcom,cam-jpeg, qcom,csiphy-v2.1.2, etc.) have no upstream bindings
   • This is expected for vendor camera subsystem — document in commit message or add vendor bindings if required

3. For pinctrl unevaluated properties:

   • Add patternProperties to the TLMM binding to allow camera pin state names (cam-sensor-*, cci*-active, cci*-suspend)

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-evk-camx.dtbo
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/purwa-camx-el2.dtb

---

❌ check-patch-compliance

Root cause: All 5 commits use the QCLINUX: prefix, which is not in the checker's allowed prefix list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: arm64: dts: qcom: hamoa: add CAMX EL2 overlay
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port...
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic...
Commit summary does not start with a required prefix

Analysis:

• Commit 1 (arm64: dts: qcom: hamoa: add CAMX EL2 overlay) has no prefix at all — this is a genuine error
• Commits 2-5 use QCLINUX: prefix — this is a known checker limitation

The check-patch-compliance checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). Vendor-only prefixes like QCLINUX: and PENDING: always fail this check, even though they are valid prefixes for the tree.

Fix:

For commit 1 (no prefix):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: hamoa: add CAMX EL2 overlay"
git rebase --continue

For commits 2-5 (QCLINUX: prefix):

• No action needed — this is a known checker limitation for vendor-only commits
• These commits are correctly prefixed with QCLINUX: for vendor-specific changes
• The checker will always fail for QCLINUX: commits; this is expected behavior

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch — Fix 2 commits with missing commit descriptions (move description text from subject to body)
2. dtb-check — Fix camera overlay DTB validation errors (add #address-cells/#size-cells/ranges to bus nodes, fix reg properties)
3. check-patch-compliance — Add QCLINUX: prefix to commit 1 (arm64: dts: qcom: hamoa: add CAMX EL2 overlay)

Note: The check-patch-compliance failures for commits 2-5 are a known limitation — QCLINUX: is a valid vendor prefix but not accepted by this checker. No action needed for those.