Skip to content

FROMLIST: arm64: dts: qcom: kaanapali: add reboot-mode support#1287

Merged
jiegan0107 merged 1 commit into
qualcomm-linux:tech/all/dt/kaanapalifrom
LXQUALCOMM:tech/all/dt/kaanapali
Jun 2, 2026
Merged

FROMLIST: arm64: dts: qcom: kaanapali: add reboot-mode support#1287
jiegan0107 merged 1 commit into
qualcomm-linux:tech/all/dt/kaanapalifrom
LXQUALCOMM:tech/all/dt/kaanapali

Conversation

@LXQUALCOMM
Copy link
Copy Markdown

Add PSCI SYSTEM_RESET2 reboot-modes for kaanapali-mtp and kaanapali-qrd for use by the psci-reboot-mode driver.

The following modes are defined:

  • bootloader: reboot into fastboot mode for fastboot flashing.
  • edl: reboot into emergency download mode for image loading via the Firehose protocol.

Link: https://lore.kernel.org/all/20260529-psci_sys_reset-dt-changes-for-pakala-v1-2-7c32161cf50b@oss.qualcomm.com/

@qcomlnxci qcomlnxci requested review from a team, aiquny, idlethread and quic-kaushalk and removed request for a team June 1, 2026 09:17
Add PSCI SYSTEM_RESET2 reboot-modes for kaanapali-mtp and kaanapali-qrd
for use by the psci-reboot-mode driver.

The following modes are defined:
- bootloader: reboot into fastboot mode for fastboot flashing.
- edl: reboot into emergency download mode for image loading via
  the Firehose protocol.

Link: https://lore.kernel.org/all/20260529-psci_sys_reset-dt-changes-for-pakala-v1-2-7c32161cf50b@oss.qualcomm.com/

Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
@qlijarvis
Copy link
Copy Markdown

PR #1287 — validate-patch

PR: #1287

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — but points to pakala patch series, not kaanapali
  2. Lore link matches PR commits: No — fundamental platform mismatch (pakala vs kaanapali)
  3. Upstream patch status: Cannot verify (network restricted); likely ⏳ Decision Pending based on recent v1 posting date (2026-05-29)
  4. PR present in qcom-next: Not checked — repo access issues and search timeout
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1287 - PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support
Upstream commit: https://lore.kernel.org/all/20260529-psci_sys_reset-dt-changes-for-pakala-v1-2-7c32161cf50b@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Lore link is for pakala, PR modifies kaanapali files
Body preserves rationale ⚠️ Cannot verify without network access to fetch upstream
Fixes tag present/correct N/A New feature, no Fixes tag expected
Authorship preserved ⚠️ Cannot verify - network restricted
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
kaanapali-mtp.dts Lore link references pakala, not kaanapali
kaanapali-qrd.dts Lore link references pakala, not kaanapali
kaanapali.dtsi Lore link references pakala, not kaanapali

Issues

  1. Critical: Target platform mismatch

    • Lore message-ID: 20260529-psci_sys_reset-dt-changes-for-**pakala**-v1-2-...
    • PR modifies: arch/arm64/boot/dts/qcom/**kaanapali**-{mtp,qrd}.dts and kaanapali.dtsi
    • The linked upstream patch is for a different platform (pakala) than what this PR changes (kaanapali)
  2. Incorrect commit prefix

    • Uses: PENDING: (work-in-progress, not yet posted)
    • Has: lore.kernel.org link present
    • Should be: FROMLIST: (posted to mailing list, not yet merged)
    • Per skill guidelines: PENDING: commits should have "No link expected"
  3. Cannot verify diff content match

    • Network restrictions prevent fetching the upstream lore patch
    • Even if fetched, the platform mismatch (pakala vs kaanapali) means the diff cannot match

Verdict

Do not merge. The lore link points to a patch series for the pakala platform, but this PR modifies kaanapali device tree files. This is either:

  • A copy-paste error where the wrong lore link was included, or
  • An adaptation of a pakala patch to kaanapali that should be documented differently

Required fixes:

  1. If this is an independent kaanapali change not yet posted upstream: remove the lore link and keep PENDING: prefix
  2. If this is adapted from a pakala patch: document the adaptation in the commit message and use appropriate prefix
  3. If there's a separate kaanapali patch on lore: update the Link: to the correct message-ID and change prefix to FROMLIST:

Final Summary

  1. Lore link present: Yes — but points to pakala patch series, not kaanapali
  2. Lore link matches PR commits: No — fundamental platform mismatch (pakala vs kaanapali)
  3. Upstream patch status: Cannot verify (network restricted); likely ⏳ Decision Pending based on recent v1 posting date (2026-05-29)
  4. PR present in qcom-next: Not checked — repo access issues and search timeout

@qlijarvis
Copy link
Copy Markdown

PR #1287 — checker-log-analyzer

PR: #1287
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26746139639

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Invalid prefix: PENDING: not in allowed list
tag-check Commit has a prefix (though not accepted by compliance checker)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1287 - PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26746139639

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Invalid prefix: PENDING: not in allowed list
tag-check Commit has a prefix (though not accepted by compliance checker)

❌ check-patch-compliance

Root cause: The commit uses PENDING: prefix, which is not in the checker's allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support
Commit summary does not start with a required prefix

Analysis:

The commit subject starts with PENDING:, but check-patch-compliance only accepts these prefixes:

  • FROMLIST: — patch posted to mailing list
  • FROMGIT: — patch from maintainer tree
  • UPSTREAM: — patch merged into mainline
  • BACKPORT: — backported with modifications

The commit does include a Link: tag pointing to lore.kernel.org:

Link: https://lore.kernel.org/all/20260529-psci_sys_reset-dt-changes-for-pakala-v1-2-7c32161cf50b@oss.qualcomm.com/

This indicates the patch was posted upstream, so the correct prefix should be FROMLIST:.

Fix:

Change the commit subject prefix from PENDING: to FROMLIST::

git rebase -i df3ae9703774b70a7b7758b53498a25de9f87174
# Mark commit f39f10a43ed8 as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: kaanapali: add reboot-mode support"
# Keep the rest of the commit message unchanged
git rebase --continue

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base df3ae9703774b70a7b7758b53498a25de9f87174 \
  --head f39f10a43ed82c742416f4f0579972f19e8de3d8

Verdict

1 blocker to fix before merge: Change PENDING: prefix to FROMLIST: since the patch has been posted to the mailing list (lore link is present in the commit message).

@LXQUALCOMM LXQUALCOMM force-pushed the tech/all/dt/kaanapali branch from f39f10a to 8d678b7 Compare June 1, 2026 10:08
@LXQUALCOMM LXQUALCOMM changed the title PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support FROMLIST: arm64: dts: qcom: kaanapali: add reboot-mode support Jun 1, 2026
@qcomlnxci qcomlnxci requested a review from a team June 1, 2026 10:10
@jiegan0107 jiegan0107 merged commit 0fa62a7 into qualcomm-linux:tech/all/dt/kaanapali Jun 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants