Skip to content

FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node#1280

Open
arakshit011 wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
arakshit011:lemans-ice-ufs-opp-table
Open

FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node#1280
arakshit011 wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
arakshit011:lemans-ice-ufs-opp-table

Conversation

@arakshit011
Copy link
Copy Markdown

Qualcomm Inline Crypto Engine (ICE) platform driver now supports an optional OPP-table.

Add OPP-table for ICE UFS device nodes for LeMans platform.

Testing:

  • dtbs_check
  • Validated on LeMans-evk platform

Link: https://lore.kernel.org/all/20260530-add-opp-table-for-lemans-ice-ufs-v2-1-2b46d3ac37d5@oss.qualcomm.com/
Signed-off-by: Abhinaba Rakshit abhinaba.rakshit@oss.qualcomm.com
CRs-Fixed: 4554448

…node

Qualcomm Inline Crypto Engine (ICE) platform driver now supports
an optional OPP-table.

Add OPP-table for ICE UFS device nodes for LeMans platform.

Link: https://lore.kernel.org/all/20260530-add-opp-table-for-lemans-ice-ufs-v2-1-2b46d3ac37d5@oss.qualcomm.com/
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, knaveen-qc, ndechesne and quicAspratap and removed request for a team May 29, 2026 21:20
@arakshit011 arakshit011 changed the title FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device … FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node May 29, 2026
@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1280

PR: #1280
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26662799715

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/lemans.dtsi Yes PR modifies lemans.dtsi which conflicts with changes from topic/tech/all/dt/qcs9100 branch already merged into the integration base

Verdict

This is a merge conflict, not a compilation error. The PR cannot be automatically merged with the current integration branch due to conflicting changes in lemans.dtsi.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1280

PR: #1280
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26662799715

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/lemans.dtsi No (integration issue) PR modifies the ICE UFS device node which was already modified by topic/tech/all/dt/qcs9100 branch merged earlier in the build workflow

Verdict

This is not a compilation error. The build failed during the merge stage due to a conflict between PR #1280 and the topic/tech/all/dt/qcs9100 topic branch. Both modify the same ICE device node in lemans.dtsi. The PR changes are syntactically correct but require manual conflict resolution.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

PR #1280 — validate-patch

PR: #1280

Verdict Issues Detailed Report
PARTIAL 0 Full report

Final Summary

  1. Lore link present: Yes — properly formatted Link: tag with v2 revision message-ID
  2. Lore link matches PR commits: Cannot verify — lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: Cannot verify — network access required to fetch thread and check for acceptance/rejection signals
  4. PR present in qcom-next: No — commit not found in qcom-next; patch may not have landed yet (consistent with FROMLIST status)
Verdict: PARTIAL — click to expand

🔍 Patch Validation

PR: #1280 - FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node
Upstream commit: https://lore.kernel.org/all/20260530-add-opp-table-for-lemans-ice-ufs-v2-1-2b46d3ac37d5@oss.qualcomm.com/
Verdict: ⏭️ PARTIAL (network restricted — upstream comparison skipped)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify — lore.kernel.org unreachable
Body preserves rationale Clear description of ICE OPP-table support
Fixes tag present/correct N/A Not a bug fix; no Fixes tag expected
Authorship preserved FROMLIST: author in From: field is correct; submitter is the author
Backport note (if applicable) N/A FROMLIST commit, not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans.dtsi ⏭️ Cannot compare to upstream — network restricted

Commit Message Analysis

✅ Strengths:

  1. Proper FROMLIST prefix — indicates patch posted to mailing list but not yet merged
  2. Lore link presentLink: tag correctly formatted with v2 revision URL
  3. Clear rationale — explains that ICE driver now supports optional OPP-table
  4. Proper authorshipFrom: matches Signed-off-by: (author is submitter)
  5. Consistent with similar commits — author has identical commits for monaco and kodiak platforms in qcom-next

⚠️ Observations:

  1. Message-ID indicates v2 revision — the lore link contains v2-1, suggesting this is the second revision of the patch series
  2. Date mismatch — commit date is May 25, 2026, but lore message-ID is 20260530 (May 30, 2026), suggesting the patch was posted to the list after the commit was created locally
  3. No upstream status information — cannot verify if patch has been accepted, rejected, or is still under review due to network restrictions

Verdict

Cannot complete full validation due to network restrictions preventing lore.kernel.org access.

What was verified:

  • ✅ Lore link is present and properly formatted
  • ✅ Commit message structure follows kernel conventions
  • ✅ FROMLIST prefix is appropriate for a patch posted to mailing list
  • ✅ Authorship is consistent (author is submitter)
  • ⚠️ Commit not found in qcom-next (may not have landed yet)

What could not be verified:

  • ❌ Diff content comparison against upstream lore patch
  • ❌ Upstream patch acceptance status (ACKed/NACKed/Pending)
  • ❌ Whether PR diff faithfully represents the lore posting

Recommendation:
The commit message structure and metadata are correct for a FROMLIST commit. However, manual verification is required to:

  1. Confirm the PR diff matches the v2 lore posting exactly
  2. Check if the upstream patch has received maintainer feedback or acceptance
  3. Verify the date discrepancy (commit created May 25, posted May 30)

Final Summary

  1. Lore link present: Yes — properly formatted Link: tag with v2 revision message-ID
  2. Lore link matches PR commits: Cannot verify — lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: Cannot verify — network access required to fetch thread and check for acceptance/rejection signals
  4. PR present in qcom-next: No — commit not found in qcom-next; patch may not have landed yet (consistent with FROMLIST status)

@qlijarvis
Copy link
Copy Markdown

PR #1280 — checker-log-analyzer

PR: #1280
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26662799944

Checker Result Summary
Checker Result Summary
checkpatch Merge conflict - CI infrastructure issue
dt-binding-check Merge conflict - CI infrastructure issue
dtb-check Merge conflict - CI infrastructure issue
sparse-check Merge conflict - CI infrastructure issue
check-uapi-headers Merge conflict - CI infrastructure issue
check-patch-compliance Merge conflict - CI infrastructure issue
tag-check ⏭️ Skipped (target branch is qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1280 - FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26662799944

Checker Result Summary
checkpatch Merge conflict - CI infrastructure issue
dt-binding-check Merge conflict - CI infrastructure issue
dtb-check Merge conflict - CI infrastructure issue
sparse-check Merge conflict - CI infrastructure issue
check-uapi-headers Merge conflict - CI infrastructure issue
check-patch-compliance Merge conflict - CI infrastructure issue
tag-check ⏭️ Skipped (target branch is qcom-next)

❌ All Checkers — Merge Conflict (CI Infrastructure Issue)

Root cause: The CI workflow failed to merge PR #1280 with the integration branch due to a merge conflict in arch/arm64/boot/dts/qcom/lemans.dtsi when merging with topic branch topic/tech/all/dt/qcs9100.

Failure details:

Merging topic branch: topic/tech/all/dt/qcs9100
Auto-merging arch/arm64/boot/dts/qcom/lemans.dtsi
CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/lemans.dtsi
Automatic merge failed; fix conflicts and then commit the result.
Merge failed or conflicts detected. Aborting merge.
##[error]Process completed with exit code 3.

Analysis:

This is not a patch quality issue. All six checkers (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) failed at the merge stage before they could run their actual validation checks.

The PR modifies arch/arm64/boot/dts/qcom/lemans.dtsi to add an OPP-table for the ICE UFS device node. The CI workflow attempts to merge the PR with the baseline (qcom-next) plus topic branches, and the topic branch topic/tech/all/dt/qcs9100 contains conflicting changes to the same file.

Patch quality assessment:

From the patch content itself:

  • Subject prefix: Correctly uses FROMLIST: prefix
  • Link tag: Contains valid lore.kernel.org link
  • Signed-off-by: Present
  • Content: Adds OPP-table with proper DT syntax (operating-points-v2, opp-hz, required-opps)
  • Scope: DTS-only change, no C/H files modified

Fix:

This is a CI workflow issue, not a patch defect. The PR author needs to:

  1. Rebase the PR on the latest integration branch that includes topic/tech/all/dt/qcs9100:

    # Fetch the latest from the base repository
    git fetch origin qcom-next
    
    # Rebase your branch
    git rebase origin/qcom-next
    
    # Resolve the merge conflict in arch/arm64/boot/dts/qcom/lemans.dtsi
    # The conflict is likely in the ICE device node section
    
    # After resolving:
    git add arch/arm64/boot/dts/qcom/lemans.dtsi
    git rebase --continue
    
    # Force push to update the PR
    git push --force-with-lease
  2. Alternative: Wait for the conflicting topic branch to be merged/removed, then re-trigger CI.

Reproduce locally:

To reproduce the merge conflict:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-next
git fetch origin tech/all/dt/qcs9100:topic/tech/all/dt/qcs9100
git merge topic/tech/all/dt/qcs9100
git fetch https://github.com/qualcomm-linux/kernel-topics.git pull/1280/head:pr-1280
git merge --no-commit pr-1280
# Conflict will appear in arch/arm64/boot/dts/qcom/lemans.dtsi

📋 Tag-Check (Manual)

Status: ⏭️ Skipped — Target branch is qcom-next

The tag-check (subject prefix validation) is only mandatory for branches other than qcom-next and qcom-next-staging. Since this PR targets qcom-next, the check does not apply.

For reference, the commit subject is:

FROMLIST: arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node

This would pass tag-check if it were required (valid FROMLIST: prefix with proper Link: tag).

Verdict

Cannot assess patch quality — All checkers blocked by merge conflict.

The patch itself appears well-formed based on manual inspection:

  • Proper subject prefix and Link tag
  • Valid DT syntax for OPP-table
  • Appropriate scope (DTS-only)

Action required: Rebase the PR on the latest qcom-next + topic branches to resolve the merge conflict, then re-trigger CI to get actual checker results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants