Add fedora/rpm package build support#13
Merged
bwarden merged 16 commits intoqualcomm-linux:mainfrom Apr 14, 2026
Merged
Conversation
bwarden
force-pushed
the
feat/add-fedora-support
branch
2 times, most recently
from
d97a2c6 to
4557482
Compare
bwarden
force-pushed
the
feat/add-fedora-support
branch
from
a10be76 to
ccd3579
Compare
bwarden
force-pushed
the
feat/add-fedora-support
branch
from
bcf6ace to
de47b4a
Compare
Contributor
Author
|
This will of course require the repo to be modified to have build-deb-arm64 and build-rpm-arm64 as required checks instead of build-image-arm64. |
bwarden
force-pushed
the
feat/add-fedora-support
branch
from
0aa9337 to
de74e84
Compare
bwarden
force-pushed
the
feat/add-fedora-support
branch
2 times, most recently
from
45dd14e to
fb01cb3
Compare
simonbeaudoin0935
requested changes
Apr 7, 2026
bwarden
force-pushed
the
feat/add-fedora-support
branch
2 times, most recently
from
5b184a8 to
184c52f
Compare
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Add logic to scan the relevant Dockerfiles to determine whether the target images are debian/ubuntu based. Applies when rebuilding all Docker images. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Docker image should include "fedora.rawhide", not just "rawhide", for example. More important when dealing with numeric releases like RHEL 8 or Fedora 44. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
When installing base or extra packages for DNF-based distros, make sure we only pass dnf a non-empty list, as it will exit with a failure otherwise. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Also add a stub to simulate pushing the images. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
These take a while to build, so might as well be parallel. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
…y changes docker_deb_build.py was reworked to omit the arch name from docker container names, so make the equivalent changes to docker_rpm_build. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Per review feedback, move the distinct actions back into a single, converged workflow. Also enable RPM image upload (remove `echo`) Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
bwarden
force-pushed
the
feat/add-fedora-support
branch
from
184c52f to
547196d
Compare
Contributor
Author
|
I found how to update the required checks. If this looks good, it can be merged, and I'll update the checks to require |
Contributor
Author
|
|
bwarden
force-pushed
the
feat/add-fedora-support
branch
from
cdab61d to
547196d
Compare
Previously, we set a default of rawhide if no distro was specified for docker_rpm_build. If --rebuild was passed without a specific distro, only the rawhide container would be built. Rework to build all detected RPM-based containers in that case. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've introduced a tool to create docker images for the RPM-based distributions, based off of the deb tool. For both tools, I implemented the ability to deduce which docker files apply to each tool, so rebuilding all images only rebuilds those in the family that tool is intended for.
I've also reworked the workflows and actions to split them up -- debian images take longer to build and there are currently more of them, so it helps to parallelize the image build flows. That also meant pushing upload into separate actions, one for deb and one for rpm.
Hopefully I've accounted for everything here to at least successfully produce Fedora rawhide and Fedora 44 images as a proof of concept, without breaking debian builds; then I can continue working on docker_rpm_build.py for our actual needs.