Improve the welcome page & Open the walkthrough instead of the welcome if qt-sm is installed#508
Open
OrkunTokdemir wants to merge 3 commits into
Open
Conversation
OrkunTokdemir
commented
Jun 22, 2026
OrkunTokdemir
commented
Collaborator
- qt-core: Restore Welcome page webview on window reload
- qt-core: Add Qt setup walkthrough entry to Welcome page
- qt-core: Open qt-sm walkthrough on activation until completed
The Welcome page webview was not restored after a window reload because
no WebviewPanelSerializer was registered for it.
Register a serializer that re-attaches the restored panel to
WelcomePageController, and add the corresponding onWebviewPanel
activation event so the extension activates to perform the restore.
Also give the Welcome page a unique view type
('ViewTypeWelcomePage'); it previously reused the Courses browser's
'ViewTypeCoursesBrowser', which would have prevented the serializer
from distinguishing the two panels.
Add a "Set up Qt" item to the Get started section of the Welcome page that opens qt-sm's guided walkthrough via the qt-sm.openWalkthrough command. The item is shown dynamically: the data reply now reports whether the qt-sm extension (theqtcompany.qt-sm) is installed, and the Get started list only includes the walkthrough entry when it is available. The list is made reactive so it updates once the availability is loaded.
On activation, open the qt-sm "Get Started" walkthrough instead of the welcome page while it is available and not yet completed. Availability is detected via the theqtcompany.qt-sm extension, and completion via the qt-sm.getStartedDone setting that qt-sm maintains. Once onboarding is done (or qt-sm is not installed), the welcome page is shown as before, subject to showWelcomePageOnActivation. Move the qt-sm availability check into a shared welcome/walkthrough module so both the activation flow and the data dispatcher use it.
OrkunTokdemir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.