Feature/215 netsuite record based support#219
Merged
nickmazurenko merged 4 commits intodevelopfrom Feb 16, 2026
Merged
Conversation
…earch records action
… into feature/215-netsuite-record-based-support
Contributor
There was a problem hiding this comment.
Pull request overview
Adds record-based (table/list/search/CRUD) support for the NetSuite connector, including SuiteQL WHERE building, REST record operations, and i18n metadata for supported expressions. This also introduces a comprehensive NetSuite record-based test suite and CI env wiring for NetSuite OAuth refresh-token credentials.
Changes:
- Add NetSuite record-based API implementation: expressions, table listing, dynamic record schema discovery, SuiteQL search iterator, and REST create/update/delete helpers.
- Extend NetSuite i18n with expression labels/descriptions and update generated i18n types accordingly.
- Add NetSuite record-based unit/integration tests and expose NetSuite OAuth env vars in the PR workflow.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
ts/src/apps/netsuite/index.ts |
Wires NetSuite into TQoreRecordBasedApp (table list, expressions, schema, search, CRUD). |
ts/src/apps/netsuite/helpers/record-based/apply-where-condition.ts |
Converts Qore WHERE trees into SuiteQL WHERE clauses. |
ts/src/apps/netsuite/helpers/record-based/constants.ts |
Shared escaping/type inference/caching + REST request helper + ID discovery. |
ts/src/apps/netsuite/helpers/record-based/search-records.ts |
SuiteQL-backed paginated search iterator returning column format. |
ts/src/apps/netsuite/helpers/record-based/create-records.ts |
Sequential REST create with follow-up GET + column-format output. |
ts/src/apps/netsuite/helpers/record-based/update-records.ts |
Finds matching IDs via SuiteQL then PATCHes each record. |
ts/src/apps/netsuite/helpers/record-based/delete-records.ts |
Finds matching IDs via SuiteQL then DELETEs each record. |
ts/src/apps/netsuite/helpers/record-based/get-table-list.ts |
Lists available record types as “tables” via existing allowed-values helper. |
ts/src/apps/netsuite/helpers/record-based/get-record-type.ts |
Builds dynamic schema by inspecting a sample SuiteQL row. |
ts/src/apps/netsuite/helpers/record-based/get-expressions.ts |
Declares supported filter operators and maps them to app i18n. |
ts/src/apps/netsuite/helpers/record-based/get-search-options.ts |
Declares orderBy options for SuiteQL sorting. |
ts/src/i18n/en/apps/NetSuite/index.ts |
Adds localized metadata for NetSuite record-based expressions. |
ts/src/i18n/i18n-types.ts |
Updates generated translation types to include NetSuite expressions. |
ts/src/tests/netsuite-record-based.test.ts |
Adds unit + integration coverage for record-based helpers (currently skipped). |
.github/workflows/pull_request.yml |
Adds NetSuite OAuth env vars from TEST_VARIABLES secrets for CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…netsuite record based support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.