call set_options_post_auth hooks for non-OAuth2 connections#218
Merged
nickmazurenko merged 4 commits intodevelopfrom Feb 16, 2026
Merged
call set_options_post_auth hooks for non-OAuth2 connections#218nickmazurenko merged 4 commits intodevelopfrom
nickmazurenko merged 4 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TypeScriptAppRestConnection to execute REST set_options_post_auth / set_options_post_auth_code hooks for non-OAuth2 connections during connection construction, aligning behavior with the existing OAuth2 post-auth update flow.
Changes:
- Invoke post-auth hooks in
TypeScriptAppRestConnection::getConfig()whenoauth2_grant_typeis unset/none. - Merge returned options into connection opts and update the connection URL when a URL is returned by the hook.
- Update the copyright year range in the module header.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The CI's DataProvider v2.3.0 now requires a "groups" key in app registrations. Add groups: ['Other'] to the External-app custom app example to fix the remaining CI failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davidnich
approved these changes
Feb 16, 2026
nickmazurenko
deleted the
feature/217-set-options-post-auth-non-oauth2
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.