add active campaign record based support#212
Merged
nickmazurenko merged 3 commits intodevelopfrom Feb 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds record-based (table/record) support to the ActiveCampaign app, enabling standardized table listing, schema discovery, searching (with expressions), and CRUD operations via the record-based interface.
Changes:
- Added ActiveCampaign record-based integration to the app configuration (tables, record types, expressions, search + CRUD).
- Implemented record-based helper modules (filtering/sorting, schema building incl. custom fields, create/update/delete/search).
- Added i18n entries for record-based expressions and a comprehensive unit/integration test suite for record-based behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/src/apps/active-campaign/index.ts | Wires record-based capabilities (table list, schema, expressions, search options, CRUD) into the ActiveCampaign app definition. |
| ts/src/apps/active-campaign/helpers/record-based/apply-where-condition.ts | Implements hybrid server/client WHERE handling plus client-side filtering/sorting utilities. |
| ts/src/apps/active-campaign/helpers/record-based/constants.ts | Defines entity configs, standard fields, payload/record transforms, and shared constants. |
| ts/src/apps/active-campaign/helpers/record-based/create-records.ts | Implements record-based create (including deal custom-field writes). |
| ts/src/apps/active-campaign/helpers/record-based/delete-records.ts | Implements record-based delete with WHERE-based selection. |
| ts/src/apps/active-campaign/helpers/record-based/get-expressions.ts | Defines supported expressions/operators for record-based searching (localized via i18n). |
| ts/src/apps/active-campaign/helpers/record-based/get-record-type.ts | Builds record schema dynamically, including custom fields fetched from ActiveCampaign APIs. |
| ts/src/apps/active-campaign/helpers/record-based/get-search-options.ts | Defines record-based search options (notably orderBy). |
| ts/src/apps/active-campaign/helpers/record-based/get-table-list.ts | Returns supported tables (Contacts, Deals, Accounts). |
| ts/src/apps/active-campaign/helpers/record-based/index.ts | Barrel export for record-based helpers/constants. |
| ts/src/apps/active-campaign/helpers/record-based/search-records.ts | Implements iterator-based searching with pagination + hybrid filtering and optional custom-field enrichment. |
| ts/src/apps/active-campaign/helpers/record-based/update-records.ts | Implements record-based update with WHERE-based selection (including deal custom-field writes). |
| ts/src/i18n/en/apps/ActiveCampaign/index.ts | Adds localized strings for the record-based expression operators. |
| ts/src/i18n/i18n-types.ts | Updates generated i18n typings to include the new ActiveCampaign expression keys. |
| ts/src/tests/active-campaign-record-based.test.ts | Adds unit tests for record-based helpers and optional integration tests for real API CRUD cycles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ts/src/apps/active-campaign/helpers/record-based/get-search-options.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ts/src/apps/active-campaign/helpers/record-based/apply-where-condition.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.