Skip to content

Comments

add record based support for quickbooks#211

Merged
nickmazurenko merged 3 commits intodevelopfrom
feature/209-quickbooks-record-based
Feb 9, 2026
Merged

add record based support for quickbooks#211
nickmazurenko merged 3 commits intodevelopfrom
feature/209-quickbooks-record-based

Conversation

@nickmazurenko
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 9, 2026 12:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds record-based (table/record CRUD) support to the QuickBooks app, including schema/expressions metadata and iterator-based search, plus accompanying i18n and tests.

Changes:

  • Introduces QuickBooks record-based helpers for table listing, record typing, search (iterator), and batch create/update/delete.
  • Adds QuickBooks search expressions + search options (orderBy) and wires record-based functions into the app export.
  • Adds extensive unit/integration tests and updates i18n typings/translations to include expression metadata.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
ts/src/apps/quickbooks/index.ts Wires the new record-based interface into the QuickBooks app export.
ts/src/apps/quickbooks/helpers/record-based/index.ts Barrel export for all record-based helper functions.
ts/src/apps/quickbooks/helpers/record-based/constants.ts Defines supported entities, capabilities, schemas, and helper utilities for record-based ops.
ts/src/apps/quickbooks/helpers/record-based/get-table-list.ts Implements record-based table listing via supported entity names.
ts/src/apps/quickbooks/helpers/record-based/get-record-type.ts Returns a static schema (record type) per QuickBooks entity.
ts/src/apps/quickbooks/helpers/record-based/get-expressions.ts Defines supported WHERE/search expressions and maps them to app i18n.
ts/src/apps/quickbooks/helpers/record-based/get-search-options.ts Defines record-based search options (orderBy).
ts/src/apps/quickbooks/helpers/record-based/apply-where-condition.ts Converts WHERE trees into server-side criteria + client-side filtering fallback.
ts/src/apps/quickbooks/helpers/record-based/search-records.ts Adds iterator-based record search with filtering/sorting and pagination.
ts/src/apps/quickbooks/helpers/record-based/create-records.ts Implements batch create via QuickBooks batch API.
ts/src/apps/quickbooks/helpers/record-based/update-records.ts Implements search-first + batch update with SyncToken handling.
ts/src/apps/quickbooks/helpers/record-based/delete-records.ts Implements search-first + batch delete with SyncToken handling and safety checks.
ts/src/i18n/en/apps/Quickbooks/index.ts Adds English i18n strings for the new expression operators.
ts/src/i18n/i18n-types.ts Updates generated i18n type definitions to include expressions under QuickBooks.
ts/src/tests/quickbooks-record-based.test.ts Adds unit tests for helpers and integration tests for CRUD/search against QuickBooks sandbox.
ts/src/global/helpers/index.ts Minor typing adjustments impacting trigger mapping and option normalization.
ts/src/global/helpers/README_QORE_API_CLIENT.md Removed documentation file (scope appears unrelated to QuickBooks record-based support).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nickmazurenko nickmazurenko linked an issue Feb 9, 2026 that may be closed by this pull request
Copilot AI review requested due to automatic review settings February 9, 2026 22:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nickmazurenko nickmazurenko merged commit 9790d96 into develop Feb 9, 2026
7 checks passed
@nickmazurenko nickmazurenko deleted the feature/209-quickbooks-record-based branch February 9, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add QuickBooks Record Based Support

1 participant