Add sandboxing, fix memory leaks, and fix documentation build#2
Closed
Add sandboxing, fix memory leaks, and fix documentation build#2
Conversation
- Add QoreSandboxManager filesystem access checks before all file I/O operations in CairoSurface (SVG/PS create, PNG load/write) and CairoSvgReader (SVG file load) - Add qore_check_io_interrupt() calls before blocking I/O for interruptible I/O support - Fix memory leaks: add ReferenceHolder for QPP object parameters in setSourceSurface, setSource, createForSurface, and renderTo per QPP Object Parameter Handling pattern - Fix double-ref leak in CairoContext constructor (HARD_QORE_VALUE_OBJ_DATA already adds reference via getReferencedPrivateData) - Add private constructors to CairoSurface and CairoPattern for proper QPP lifecycle management Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d fix warnings - Add docs/footer_template.html required by Doxygen template - Implement two-phase doc build in CMakeLists.txt per qore-module-structure.md: initial pass suppresses WARN_IF_DOC_ERROR, final pass includes CairoDataProvider.tag for cross-module references - Escape <action> in data provider doc comments to prevent Doxygen HTML tag warnings - Note: build requires cmake -DCMAKE_INSTALL_PREFIX=/usr to match Qore installation prefix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Changes already merged to develop; closing stale PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QoreSandboxManagerHelperfilesystem access checks before all file I/O operationsqore_check_io_interrupt()calls before blocking I/O for interruptible I/O supportReferenceHolderfor QPP object parameters per Object Parameter Handling patternCairoContextconstructorCairoSurfaceandCairoPatternfor proper QPP lifecycleTest plan
make docsbuilds successfully with two-phase doc build🤖 Generated with Claude Code