chore: fix new clippy warnings (derive default)#21
Conversation
Comment on lines
+34
to
+35
| tray_icon::MouseButtonState::Up => MouseButtonState::Down, | ||
| tray_icon::MouseButtonState::Down => MouseButtonState::Up, |
There was a problem hiding this comment.
🔴 MouseButtonState mapping is inverted in From implementation
The From<tray_icon::MouseButtonState> implementation incorrectly inverts the mouse button state mapping, causing Up to be reported as Down and vice versa.
Click to expand
Mechanism
The conversion from tray_icon::MouseButtonState to Tauri's MouseButtonState has the mapping inverted:
match value {
tray_icon::MouseButtonState::Up => MouseButtonState::Down, // WRONG: should be Up
tray_icon::MouseButtonState::Down => MouseButtonState::Up, // WRONG: should be Down
}Impact
When a user clicks on a tray icon:
- A mouse button press (
Downfromtray_icon) will be reported asUpto the application - A mouse button release (
Upfromtray_icon) will be reported asDownto the application
This will break any application logic that depends on the correct mouse button state, such as:
- Detecting when a button is pressed vs released
- Implementing drag operations
- Distinguishing between click start and click end
Expected vs Actual
- Expected:
tray_icon::MouseButtonState::Up→MouseButtonState::Up,tray_icon::MouseButtonState::Down→MouseButtonState::Down - Actual:
tray_icon::MouseButtonState::Up→MouseButtonState::Down,tray_icon::MouseButtonState::Down→MouseButtonState::Up
Recommendation: Fix the mapping to correctly convert the states:
match value {
tray_icon::MouseButtonState::Up => MouseButtonState::Up,
tray_icon::MouseButtonState::Down => MouseButtonState::Down,
}Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#150