chore: fix new clippy warnings (derive default)#18
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| tray_icon::MouseButtonState::Up => MouseButtonState::Up, | ||
| tray_icon::MouseButtonState::Down => MouseButtonState::Down, | ||
| tray_icon::MouseButtonState::Up => MouseButtonState::Down, | ||
| tray_icon::MouseButtonState::Down => MouseButtonState::Up, |
There was a problem hiding this comment.
MouseButtonState conversion swaps Up and Down values
High Severity
The From<tray_icon::MouseButtonState> implementation incorrectly maps Up to Down and Down to Up. This causes all tray icon mouse button state events to report the inverse of what actually occurred—a button press will be reported as released and vice versa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#150
Note
Streamlines defaults and minor ergonomics:
Defaultand marks default variants (#[default]) across multiple enums (e.g.,WindowsUpdateInstallMode,DeviceEventFilter,BundleTarget,NsisCompression,NSISInstallerMode,PatternKind,TitleBarStyle,IsolationSide,MouseButtonState,MouseButton) and removes manualimpl DefaultblocksError::MissingBundleTypeVarvia#[cfg_attr]incrates/tauri-bundler/src/error.rsTrayIconEvent::new_clickhelper; derives defaults for tray mouse types and updatesFrom<tray_icon::MouseButtonState>/MouseButtonconversionsDefaultimpls and the new tray constructorWritten by Cursor Bugbot for commit 74afca3. Configure here.