feat(cli): UTExportedTypeDeclarations support for file associations#22
Conversation
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| ), | ||
| ); | ||
|
|
||
| if association.ext.is_empty() { |
There was a problem hiding this comment.
CFBundleTypeExtensions is currently only inserted when association.ext.is_empty(), so for the common case (non-empty extensions) the key won’t be emitted and the extension-based association may not work on macOS.
🤖 Was this useful? React with 👍 or 👎
| .name | ||
| .as_ref() | ||
| .unwrap_or(&association.ext[0].0) | ||
| .expect("File association must have a name") |
There was a problem hiding this comment.
CFBundleTypeName now unconditionally .expect(...)s association.name, but the schema/docs describe name as optional (defaulting to ext[0]) and the example config omits it; this can panic during bundling.
🤖 Was this useful? React with 👍 or 👎
| if let Some(description) = &association.description { | ||
| dict.insert("UTTypeDescription".into(), description.clone().into()); | ||
| } | ||
| if let Some(content_types) = &association.content_types { |
There was a problem hiding this comment.
In UTExportedTypeDeclarations, UTTypeConformsTo is populated from association.content_types, but the config field for conformance is exportedType.conformsTo (ExportedFileAssociation::conforms_to); this seems likely to generate an incorrect UTI conformance list.
🤖 Was this useful? React with 👍 or 👎
| "UTTypeIdentifier".into(), | ||
| exported_type.identifier.clone().into(), | ||
| ); | ||
| if let Some(description) = &association.description { |
There was a problem hiding this comment.
UTTypeDescription is sourced from association.description, which is documented in the schema as Windows-only; consider clarifying the config docs/semantics if this field is now also used for macOS exported type metadata.
🤖 Was this useful? React with 👍 or 👎
1 participant
Benchmark PR from qodo-benchmark#166