Skip to content

[Blazor] Remove obsolete APIs from Components#16

Open
tomerqodo wants to merge 3 commits intoaugment_combined_20260121_augment_sentry_coderabbit_1_base_blazor_remove_obsolete_apis_from_components_pr88from
augment_combined_20260121_augment_sentry_coderabbit_1_head_blazor_remove_obsolete_apis_from_components_pr88
Open

[Blazor] Remove obsolete APIs from Components#16
tomerqodo wants to merge 3 commits intoaugment_combined_20260121_augment_sentry_coderabbit_1_base_blazor_remove_obsolete_apis_from_components_pr88from
augment_combined_20260121_augment_sentry_coderabbit_1_head_blazor_remove_obsolete_apis_from_components_pr88

Conversation

@tomerqodo
Copy link
Copy Markdown

Benchmark PR from qodo-benchmark#88

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Jan 22, 2026

🤖 Augment PR Summary

Summary: This PR removes a set of obsolete Blazor/Components public APIs and related back-compat code paths.

Changes:

  • Removed obsolete parameters and helpers such as Router.PreferExactMatches and older DataAnnotations validation extension overloads.
  • Deleted unused/obsolete types like RemoteBrowserFileStreamOptions, WebEventCallbackFactoryEventArgsExtensions, and SignOutSessionStateManager.
  • Simplified WebAssembly auth flows by removing obsolete AccessTokenResult.RedirectUrl/ctor and updating redirect logic to use InteractiveRequestUrl.
  • Updated logout handling to rely on the navigation history state-based sign-out request validation only.
  • Removed a no-op obsolete init accessor (WebRenderer.RendererId.init).
  • Removed legacy WebAssembly JS interop entrypoints (e.g., older InternalCalls.InvokeJS<...>).
  • Cleaned up associated unit tests that only exercised the removed obsolete APIs.
  • Updated PublicAPI.Unshipped.txt files to record the removals for API-compat tracking.

Technical Notes: The primary behavior changes are confined to WebAssembly authentication/logout and access-token redirect paths; the rest are API surface cleanups with corresponding API-compat annotations.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

public void Redirect()
{
if (_tokenResult.InteractionOptions != null && _tokenResult.InteractiveRequestUrl != null)
if (_tokenResult.InteractionOptions != null)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccessTokenResult.InteractiveRequestUrl is nullable, but the null-check for it was removed here; this can now pass a null URL into NavigateToLogin (or hit the ! in the else branch) and throw at runtime. Consider ensuring InteractiveRequestUrl is non-null before navigating (especially since Redirect() can be called regardless of Status).

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants