Add test coverage for prerendering closed generic components#15
Conversation
Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
🤖 Augment PR SummarySummary: Adds unit-test coverage to ensure prerendering/serialization supports closed generic Blazor components. Changes:
Technical Notes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| var preambleMarker = JsonSerializer.Deserialize<ComponentMarker>(preamble, ServerComponentSerializationSettings.JsonSerializationOptions); | ||
| Assert.NotNull(preambleMarker.PrerenderId); | ||
| Assert.Equal("webassembly", preambleMarker.Type); | ||
| Assert.Equal(typeof(GenericComponent<string>).Assembly.GetName().Name, preambleMarker.Assembly); |
There was a problem hiding this comment.
This test prerenders GenericComponent<int> but asserts the marker Assembly/TypeName for GenericComponent<string>, so it won’t validate the rendered closed generic type (and is likely to fail).
🤖 Was this useful? React with 👍 or 👎
|
|
||
| var secondDescriptor = descriptors[1]; | ||
| Assert.Equal(typeof(GenericTestComponent<string>).FullName, secondDescriptor.ComponentType.FullName); | ||
| Assert.Equal(0, secondDescriptor.Sequence); |
There was a problem hiding this comment.
In this multi-marker case, the second descriptor’s Sequence is asserted as 0, but CanParseMultipleMarkers expects the second marker to have Sequence == 1 (and CreateMarkers serializes markers in order). This looks inconsistent and likely makes the test incorrect.
🤖 Was this useful? React with 👍 or 👎
Benchmark PR from qodo-benchmark#86