Add an mcu_reset impl for the kiibohd bootloader.#25963
Merged
zvecr merged 1 commit intoqmk:developfrom Mar 28, 2026
Merged
Conversation
* fixing resetting not working on the Ergodox Infinity.
This was referenced Jan 20, 2026
|
Thank you for your contribution! |
Author
|
the upstream change has been merged into chibios. any chance of a merge? I've been running this code for over a month now with no issues. |
tzarc
approved these changes
Mar 15, 2026
Member
tzarc
left a comment
There was a problem hiding this comment.
ChibiOS and ChibiOS-Contrib submodule updates are now on develop. Should be good to go, now.
zvecr
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per the title. It was missing, and any code that needed to reset the device failed. e.g. os detection and spit keyboard watchdog.
related to #19420 (comment)
one of two PRs that replace: #25959
Types of Changes
Issues Fixed or Closed by This PR
Maybe some, not searched for them, however #19420 is partially fixed by this, but also needs fixes from chibios-control to be fully fixed, see: ChibiOS/ChibiOS-Contrib#432
Checklist