Skip to content

Add an mcu_reset impl for the kiibohd bootloader.#25963

Merged
zvecr merged 1 commit intoqmk:developfrom
hydra:fixes-for-pr-1-on-develop-a
Mar 28, 2026
Merged

Add an mcu_reset impl for the kiibohd bootloader.#25963
zvecr merged 1 commit intoqmk:developfrom
hydra:fixes-for-pr-1-on-develop-a

Conversation

@hydra
Copy link
Copy Markdown

@hydra hydra commented Jan 20, 2026

  • fixing resetting not working on the Ergodox Infinity.

Description

As per the title. It was missing, and any code that needed to reset the device failed. e.g. os detection and spit keyboard watchdog.

related to #19420 (comment)
one of two PRs that replace: #25959

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Maybe some, not searched for them, however #19420 is partially fixed by this, but also needs fixes from chibios-control to be fully fixed, see: ChibiOS/ChibiOS-Contrib#432

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

* fixing resetting not working on the Ergodox Infinity.
@github-actions
Copy link
Copy Markdown

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions Bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 10, 2026
@hydra
Copy link
Copy Markdown
Author

hydra commented Mar 11, 2026

the upstream change has been merged into chibios.

ChibiOS/ChibiOS-Contrib#432

any chance of a merge?

I've been running this code for over a month now with no issues.

@github-actions github-actions Bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 12, 2026
Copy link
Copy Markdown
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChibiOS and ChibiOS-Contrib submodule updates are now on develop. Should be good to go, now.

@tzarc tzarc requested a review from a team March 15, 2026 10:36
@zvecr zvecr merged commit 3d0ccbb into qmk:develop Mar 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants