Skip to content

update_wikidata only update progress bar every thousand #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pfps wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update_wikidata only update progress bar every thousand #233

pfps wants to merge 1 commit into from

Conversation

@pfps
Copy link

@pfps pfps commented Dec 17, 2025 •
edited
Loading

Fixes #232

This prevents excess string manipulation and communication due to updating for every message.

@pfps pfps mentioned this pull request Dec 17, 2025
Open
Qup42
Qup42 approved these changes Dec 17, 2025
View reviewed changes
Copy link
Collaborator

@Qup42 Qup42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this optimization!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qup42 Qup42 Qup42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

progress bar is expensive to show

2 participants

@pfps @Qup42