Revise API for discrete Gaussians #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsiemer
force-pushed
the
optmise_disc_gauss_api
branch
from
86790f2 to
5023b2e
Compare
Marvin-Beckmann
approved these changes
Nov 20, 2025
Comment on lines
+39
to
+50
| /// This is the global variable used in all `sample_discrete_gauss` and `sample_d` | ||
| /// functions. Its value should be in `ω(log(sqrt(n)))`. We set it (as most other libraries) | ||
| /// statically to `6.0`. | ||
| /// | ||
| /// You can use and change in an `unsafe` environment. | ||
| /// ```compile_fail | ||
| /// unsafe { TAILCUT = 4.0 }; | ||
| /// ``` | ||
| /// Make sure that the tailcut stays positive and large enough for your purposes. | ||
| /// If you use multi-threading, read up on the behaviour of a `static mut` variable. | ||
| /// Our tests only cover cases where `TAILCUT = 6.0`. | ||
| pub static mut TAILCUT: f64 = 6.0; |
Member
There was a problem hiding this comment.
nice that it ended up working. We could. consider adding a reference to a library that also does it (but probably optional)
Member
Author
There was a problem hiding this comment.
dgs does it for example. The discrete Gaussian sampler of sagemath library also takes tailcut=6 as a default. The Micciancio-Walter paper from CRYPTO'17 takes the tailcut to be 6. There are plenty of references (or in other terms: I've never seen anything else :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revises the API for discrete Gaussian sampling...
n(which was used to define the tailcut) and replacing it by astatic mutvariableTAILCUTset to 6.0 by standard (as basically any other library).degree-/entry-many Gaussian samplers forMatQandPolyOverQTesting
Not required - tests were already in place.
Checklist: