Skip to content

Enforce must_use on builder types#276

Merged
agourlay merged 1 commit into
devfrom
builders-must-use
Mar 24, 2026
Merged

Enforce must_use on builder types#276
agourlay merged 1 commit into
devfrom
builders-must-use

Conversation

@agourlay

@agourlay agourlay commented Mar 24, 2026

Copy link
Copy Markdown
Member

It is easy to misuse a builder without having the help of the compile.

  let prefetch_query = PrefetchQueryBuilder::default();
  prefetch_query.query(query.clone()); // unused return value of `PrefetchQueryBuilder` that must be used

@agourlay agourlay requested review from generall and timvisee March 24, 2026 08:00
@agourlay agourlay mentioned this pull request Mar 24, 2026
Merged
@agourlay agourlay merged commit f49e06c into dev Mar 24, 2026
2 checks passed
timvisee pushed a commit that referenced this pull request May 11, 2026
@agourlay @timvisee
Enforce must_use on builder types (#276)
d4234dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JojiiOfficial JojiiOfficial JojiiOfficial approved these changes

@generall generall Awaiting requested review from generall

@timvisee timvisee Awaiting requested review from timvisee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agourlay @JojiiOfficial