Conversation
SulthanaSaleem-QB
requested review from
elson-ae and
qburst-praven
as code owners
| location = var.location | ||
| } | ||
|
|
||
| resource "azurerm_virtual_network" "vnet" { |
There was a problem hiding this comment.
please dont create vnets here, use the existing modules under modules/vnet .
In fact try to reuse as much as possible. If your missing a module create that first.
There was a problem hiding this comment.
used existing vnet module
| depends_on = [azurerm_private_dns_zone_virtual_network_link.vlink] | ||
| } | ||
|
|
||
| resource "azurerm_mysql_flexible_database" "sqldb" { |
There was a problem hiding this comment.
I might be wrong but this can only create a flexible database. Please add options to create azurerm_sql_server based on the user's requirement.
There was a problem hiding this comment.
Single Server service, it can no longer handle all the new features, functions, and security needs and Azure Database for MySQL - Single Server is scheduled for retirement by September 16, 2024. We have 2 options while creating azure mysql db one is flexible and another one is word-press + flexible server
| server_name = azurerm_mysql_flexible_server.sqlserver.name | ||
| start_ip_address = var.mysql_firewall_start_ip | ||
| end_ip_address = var.mysql_firewall_end_ip | ||
| } |
There was a problem hiding this comment.
Also please add options to create VNET private links.
There was a problem hiding this comment.
Similaryl add as many features as possible, tht you feel will be needed,
There was a problem hiding this comment.
Added private endpoint
2 participants
No description provided.