Skip to content

fix(mcp): soul_forget always reports total_deleted=0#246

Open
IITI-tushar wants to merge 1 commit into
qbtrix:mainfrom
IITI-tushar:fix/mcp-soul-forget-total-deleted
Open

fix(mcp): soul_forget always reports total_deleted=0#246
IITI-tushar wants to merge 1 commit into
qbtrix:mainfrom
IITI-tushar:fix/mcp-soul-forget-total-deleted

Conversation

@IITI-tushar
Copy link
Copy Markdown

What does this PR do?

Fixes the soul_forget MCP tool always reporting total_deleted: 0 and tiers: {} regardless of how many memories were actually erased. The handler was reading result.get("total_deleted", 0) and result.get("tiers", {}) but MemoryManager.forget() returns keys total, episodic, semantic, and procedural. The CLI was corrected for this same mismatch in an earlier commit (see cli/main.py header line 19–20) but mcp/server.py was never updated.

Fixes #245

How to test

Reproduce before the fix:

  1. Start the MCP server and birth a soul
  2. Call soul_observe a few times with "Alice" content
  3. Call soul_forget with query="Alice", confirm=True
  4. Check response — total_deleted is always 0 before this fix
uv run pytest tests/test_mcp_sampling_engine.py tests/test_gdpr_deletion.py -v

Checklist

  • Tests pass locally (uv run pytest tests/)
  • Lint passes (uv run ruff check . && uv run ruff format --check .)
  • No secrets or credentials in the diff
  • PR title follows Conventional Commits (feat:, fix:, docs:, etc.)

Signed-off-by: Tushar Saxena <019saxenatushar@gmail.com>
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 14 days. It will be closed in 7 days if no further activity occurs. If you're still working on this, please push an update or leave a comment.

@github-actions github-actions Bot added the stale label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: soul_forget MCP tool always reports total_deleted: 0

1 participant