fix(mcp): soul_forget always reports total_deleted=0#246
Open
IITI-tushar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tushar Saxena <019saxenatushar@gmail.com>
|
This PR has been automatically marked as stale because it has not had activity in the last 14 days. It will be closed in 7 days if no further activity occurs. If you're still working on this, please push an update or leave a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
soul_forgetMCP tool always reportingtotal_deleted: 0 and tiers: {}regardless of how many memories were actually erased. The handler was readingresult.get("total_deleted", 0)andresult.get("tiers", {})butMemoryManager.forget()returns keystotal, episodic, semantic, and procedural. The CLI was corrected for this same mismatch in an earlier commit (see cli/main.py header line 19–20) but mcp/server.py was never updated.Fixes #245
How to test
Reproduce before the fix:
Checklist
uv run pytest tests/)uv run ruff check . && uv run ruff format --check .)feat:,fix:,docs:, etc.)