Skip to content

Fix typo in LFWPairs docstring#9540

Open
JSap0914 wants to merge 1 commit into
pytorch:mainfrom
JSap0914:codex/fix-lfw-indentities-typo
Open

Fix typo in LFWPairs docstring#9540
JSap0914 wants to merge 1 commit into
pytorch:mainfrom
JSap0914:codex/fix-lfw-indentities-typo

Conversation

@JSap0914

@JSap0914 JSap0914 commented Jul 5, 2026

Copy link
Copy Markdown

Summary

Fixes a typo in the LFWPairs return-value docstring: indentities -> identities.

Proof

Source proof:

  • Upstream repo: pytorch/vision
  • Base branch: main
  • Base commit checked before editing: 0bc41e67670d6a0ae5617c90e7b29a5c64ec0575
  • Current source line before the fix: torchvision/datasets/lfw.py:260 said different indentities.

Duplicate-search proof before editing:

  • gh pr list --repo pytorch/vision --state open --search 'indentities' --json ... --limit 30 returned [].
  • gh pr list --repo pytorch/vision --state open --search 'LFW identities' --json ... --limit 20 returned [].
  • gh pr list --repo pytorch/vision --state all --search 'indentities' --json ... --limit 30 returned [].
  • gh issue list --repo pytorch/vision --state all --search 'indentities' --json ... --limit 30 returned [].

Failing-first proof:

  • Before the change, python3 - <<'PY' ... assert 'different identities' in text ... PY failed with AssertionError.
  • After the change, the same assertion passed and also asserted different indentities is absent.

Verification

  • python3 - <<'PY' ... assert 'different identities' in text; assert 'different indentities' not in text; compile(text, str(path), 'exec') ... PY
  • git diff --check
  • git status --short -uno

All commands passed after the commit.

Copilot AI review requested due to automatic review settings July 5, 2026 06:34
@pytorch-bot

pytorch-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9540

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla

meta-cla Bot commented Jul 5, 2026

Copy link
Copy Markdown

Hi @JSap0914!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants