Skip to content

Validate CelebA target_type in __init__ using verify_str_arg #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunnycho100 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Validate CelebA target_type in __init__ using verify_str_arg #9449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f957839
Validate CelebA target_type in __init__ using verify_str_arg
sunnycho100 Mar 18, 2026
875de32
Merge branch 'main' into celeba-verify-str-arg-target-type
sunnycho100 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions torchvision/datasets/celeba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ def __init__(
else:
self.target_type = [target_type]

for t in self.target_type:
verify_str_arg(t, "target_type", ("attr", "identity", "bbox", "landmarks"))

if not self.target_type and self.target_transform is not None:
raise RuntimeError("target_transform is specified but target_type is empty")

Expand Down Expand Up @@ -185,9 +188,6 @@ def __getitem__(self, index: int) -> tuple[Any, Any]:
target.append(self.bbox[index, :])
elif t == "landmarks":
target.append(self.landmarks_align[index, :])
else:
# TODO: refactor with utils.verify_str_arg
raise ValueError(f'Target type "{t}" is not recognized.')

if self.transform is not None:
X = self.transform(X)
Expand Down
Loading