Improving tv_tensors wrap API for extensibility.#9398
Open
gabrielfruet wants to merge 11 commits intopytorch:mainfrom
Open
Improving tv_tensors wrap API for extensibility.#9398gabrielfruet wants to merge 11 commits intopytorch:mainfrom
gabrielfruet wants to merge 11 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9398
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 7790dac with merge base 9bf794d ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
b23ac61 to
5b0311d
Compare
zy1git
reviewed
Feb 25, 2026
Contributor
There was a problem hiding this comment.
@gabrielfruet Thanks a lot for the PR. I left two comments.
it seems that there are some test failures which need to be addressed. If you are still working on this PR, feel free to convert it to a draft. When the PR is ready to be reviewed, just convert it back.
Contributor
Author
|
@zy1git I think the PR is done. CI is red, but the errors are not related to my changes to my understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9333
Adopt a method-based wrapping, enabling user to extend functionality on subclasses of
TVTensor.This is the pythonic approach, since we have many built-ins that rely on this on pattern (e.g
len,iter,next...)This does not break backwards compatibility.