Skip to content

Remove redundant epoch_number variable in training tutorial (issue 3714) #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheralskumar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant epoch_number variable in training tutorial (issue 3714) #3787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions beginner_source/introyt/trainingyt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,18 +277,17 @@ def train_one_epoch(epoch_index, tb_writer):
# Initializing in a separate cell so we can easily add more epochs to the same run
timestamp = datetime.now().strftime('%Y%m%d_%H%M%S')
writer = SummaryWriter('runs/fashion_trainer_{}'.format(timestamp))
epoch_number = 0

EPOCHS = 5

best_vloss = 1_000_000.

for epoch in range(EPOCHS):
print('EPOCH {}:'.format(epoch_number + 1))
print('EPOCH {}:'.format(epoch + 1))

# Make sure gradient tracking is on, and do a pass over the data
model.train(True)
avg_loss = train_one_epoch(epoch_number, writer)
avg_loss = train_one_epoch(epoch, writer)


running_vloss = 0.0
Expand All @@ -311,16 +310,14 @@ def train_one_epoch(epoch_index, tb_writer):
# for both training and validation
writer.add_scalars('Training vs. Validation Loss',
{ 'Training' : avg_loss, 'Validation' : avg_vloss },
epoch_number + 1)
epoch + 1)
writer.flush()

# Track best performance, and save the model's state
if avg_vloss < best_vloss:
best_vloss = avg_vloss
model_path = 'model_{}_{}'.format(timestamp, epoch_number)
model_path = 'model_{}_{}'.format(timestamp, epoch)
torch.save(model.state_dict(), model_path)

epoch_number += 1


#########################################################################
Expand Down
Loading