[BE] Update upload bm results GHA #7612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <huydhn@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn
commented
Dec 19, 2025
| echo "DEVICE_NAME=$DEVICE_NAME" >> $GITHUB_ENV | ||
| - name: Get device type |
Contributor
Author
There was a problem hiding this comment.
This logic is from https://github.com/pytorch/pytorch-integration-testing/blob/main/.github/workflows/vllm-benchmark.yml#L139. There is a task to consolidate this into this official upload benchmark results GHA
Signed-off-by: Huy Do <huydhn@gmail.com>
This reverts commit faabc80.
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
yangw-dev
approved these changes
Dec 22, 2025
atalman
added a commit
that referenced
this pull request
Dec 23, 2025
Reverts #7612 Causing multiple failures on CI : https://github.com/pytorch/pytorch/actions/runs/20446693320/job/58754263235 Error: ``` Traceback (most recent call last): File "/home/ec2-user/actions-runner/_work/_actions/pytorch/test-infra/main/.github/actions/upload-benchmark-results/../../scripts/upload_benchmark_results.py", line 380, in <module> main() File "/home/ec2-user/actions-runner/_work/_actions/pytorch/test-infra/main/.github/actions/upload-benchmark-results/../../scripts/upload_benchmark_results.py", line 375, in main warn(f"Find no benchmark results in {args.benchmark_results}") AttributeError: 'Namespace' object has no attribute 'benchmark_results' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of changes:
DEVICE_NAMEandDEVICE_TYPEfrom https://github.com/pytorch/pytorch-integration-testing/blob/main/.github/workflows/vllm-benchmark.yml and get rid of PyTorch as a dependency from this workflow to find the device name and type. Installing PyTorch just to get this information is a wastenvidia-ml-pyas a replacement ofpynvml