Update googletest submodule dependency to enable cmake to build tests#465
Update googletest submodule dependency to enable cmake to build tests#465dwiddows wants to merge 3 commits into
Conversation
Added instructions for building and running tests using CMake and Ninja.
|
Hi @dwiddows! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Update to google/googletest at v1.17.x, used at pytorch/third_party at main · pytorch/pytorch
Fixes the following error when trying to build tests:
The problem was that the googletest dependency was older than the project's minimum cmake version. So some version declaration needed to be changed to make tests build.
Please feel free to suggest alternative guidance if there's a better way to get tests running again.