Skip to content

Cortex-M backend: fix avg_pool2d substitution function signature#20169

Merged
rascani merged 1 commit into
pytorch:mainfrom
rascani:fix-avgpool-dialect-pass-signature
Jun 9, 2026
Merged

Cortex-M backend: fix avg_pool2d substitution function signature#20169
rascani merged 1 commit into
pytorch:mainfrom
rascani:fix-avgpool-dialect-pass-signature

Conversation

@rascani

@rascani rascani commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Use dialect_pass: AtenToDialectPass parameter matching the SubstitutionFn type updated in #19676. The exported_program parameter caused a mypy arg-type error when both #19676 and #19825 landed on main.

Fixes the lintrunner-mypy failure on main.

Use `dialect_pass: AtenToDialectPass` parameter matching the
SubstitutionFn type updated in pytorch#19676. The `exported_program`
parameter caused a mypy arg-type error when both pytorch#19676 and pytorch#19825
landed on main.

Fixes the lintrunner-mypy failure on main.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rascani rascani requested a review from shoumikhin June 9, 2026 23:24
@pytorch-bot

pytorch-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20169

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani merged commit 26b4be8 into pytorch:main Jun 9, 2026
167 of 170 checks passed
@rascani rascani deleted the fix-avgpool-dialect-pass-signature branch June 9, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants