Skip to content

Cortex-M: run op tests against a selectable target#20081

Open
rascani wants to merge 3 commits into
pytorch:mainfrom
rascani:cortex-m-op-tests-target-option
Open

Cortex-M: run op tests against a selectable target#20081
rascani wants to merge 3 commits into
pytorch:mainfrom
rascani:cortex-m-op-tests-target-option

Conversation

@rascani

@rascani rascani commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Add an explicit --cortex-m-target pytest option (conftest, defaulting to cortex-m55) for the op tests. Implementation tests take the target as a parametrized fixture, so it appears in the test id and drives both the AoT config and the matching per-target FVP runner; dialect tests stay target-agnostic since their graph output does not depend on the target.

A new reusable workflow (_test_cortex_m_ops.yml) builds the runner for each target and runs only the implementation tests against it; trunk.yml invokes it for cortex-m7 and cortex-m0plus. cortex-m55 coverage continues to run on pull via the existing job.

Test plan

CI

Authored with Claude Code.

Add a --cortex-m-target pytest option (conftest, default cortex-m55). Both
the dialect and implementation op tests take the target as a parametrized
fixture, so the target appears in the test id and drives the AoT config
(and, for implementation tests, the matching per-target FVP runner built by
build_test_runner.sh).

A new reusable workflow (_test_cortex_m_ops.yml) builds the runner for each
target and runs the op suite against it; trunk.yml invokes it for cortex-m7
and cortex-m0plus. cortex-m55 runs on pull via the existing full-suite job.

Authored with Claude Code.
@pytorch-bot

pytorch-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20081

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unclassified Failures

As of commit e1f8392 with merge base 26b4be8 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2026
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani marked this pull request as ready for review June 8, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant