-
Notifications
You must be signed in to change notification settings - Fork 764
Arm backend: Add support for Zephyr as a external module #16294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arm backend: Add support for Zephyr as a external module #16294
Conversation
This commit has everything needed to build executorch from zephyr and include it as a external module without having any changes in zephyr. Based on code by BujSet. Co-authored-by: BujSet <ranganath1000@gmail.com> Co-authored-by: Zingo Andersen <zingo.andersen@arm.com> Co-authored-by: Per Held <per.held@arm.com> Change-Id: I1a1aeb8aa02f1b5e3a578dd25d031919c9925019 Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16294
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 31f8796 with merge base cf8496a ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| CONFIG_CPP=y | ||
| CONFIG_STD_CPP17=y | ||
|
|
||
| # Needed as kernels/portable/cpu/op_allclose.cpp uses isfinite() instead of std::isfinite() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a PR on it's way to fix this, it will be uploaded after this is merged as it depends on this PR
| * ethos-u-core-driver for hardware interaction. | ||
| */ | ||
|
|
||
| // Workaround for runtime/core/portable_type/c10/c10/util/Float16-math.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi @digantdesai this touches file outside Arm folders and need a non Arm review. |
|
For reference: There are some extra information about this PR in this discussions zephyrproject-rtos/zephyr#92981 |
Summary
This commit has everything needed to build executorch from zephyr and include it as a external module without having any changes in zephyr.
Based on code by BujSet.
Test plan
Tested by hand. Plan to update GitHub testing for this in later PR
cc @freddan80 @per @oscarandersson8218 @digantdesai
Co-authored-by: BujSet <ranganath1000@gmail.com>
Co-authored-by: Adrian Lundell <adrian.lundell@arm.com>
Co-authored-by: Zingo Andersen <zingo.andersen@arm.com>
Co-authored-by: Per Held <per.held@arm.com>