Empty tensor handling #3891
Open
Empty tensor handling #3891
+277
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
apbose
force-pushed
the
abose/torchTRT_empty_tensor_handling
branch
2 times, most recently
from
87ebaf5 to
547022d
Compare
apbose
force-pushed
the
abose/torchTRT_empty_tensor_handling
branch
from
547022d to
5d9d5fc
Compare
narendasan
reviewed
Dec 10, 2025
Collaborator
narendasan
left a comment
narendasan
left a comment
There was a problem hiding this comment.
@apbose this maybe be a case where we would want TRT to properly handle this rather than us doing something hacky. Lets raise it with Yuan Yuo. Dummy inputs do not feel like the right solution
| auto shape = core::util::toVec(dims); | ||
| LOG_DEBUG("Input Name: " << name << " Shape: " << dims); | ||
|
|
||
| void* tensor_addr = nullptr; |
Collaborator
There was a problem hiding this comment.
I strongly want to avoid having nullptr basically anywhere, we should be looking for some sane default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the case of empty tensor in torchTRT based on https://docs.nvidia.com/deeplearning/tensorrt/latest/inference-library/advanced.html#empty-tensors, and also focuses on concat operation edge case involving empty tensor
TODO: Might have to separate the case of concat from this PR, in the case when torch.Tensor([]) and a rank greater tensor are concatenated, which is a valid case in pytorch but not TRT.
This addressed #3865. Corresponding HF transformers issue raised - huggingface/transformers#42027 where empty tensor should not come in the first place