Skip to content

Add platform to clamav#4558

Merged
patrick91 merged 1 commit intomainfrom
clamav
Feb 5, 2026
Merged

Add platform to clamav#4558
patrick91 merged 1 commit intomainfrom
clamav

Conversation

@patrick91
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Feb 5, 2026 4:54pm

@patrick91 patrick91 merged commit 41c9e3e into main Feb 5, 2026
5 of 6 checks passed
@claude
Copy link
Contributor

claude bot commented Feb 5, 2026

Summary

This PR adds an explicit platform specification (linux/amd64) to the ClamAV service in docker-compose.yml. This change ensures consistent behavior across different architectures (particularly important for Apple Silicon/ARM Macs) by forcing the use of the AMD64 image.

Review

Architecture & Design ✅

Approved - This is a minimal, targeted change that addresses a specific compatibility issue.

  • The change follows Docker Compose best practices for multi-architecture support
  • Does not introduce any coupling or architectural concerns
  • Appropriately scoped to only affect the ClamAV service

Why This Change Matters

Adding platform: linux/amd64 is beneficial because:

  1. Consistency: Ensures all developers use the same architecture regardless of their host machine
  2. Compatibility: The ClamAV 1.2.3-47 image may have better support or be officially tested on AMD64
  3. Reproducibility: Prevents architecture-related bugs from surfacing differently across team members' machines

Considerations

Performance trade-off: On ARM machines (Apple Silicon), this forces emulation via Rosetta/QEMU, which can be slower than native ARM images. However, for a background service like ClamAV that's used for file scanning, this trade-off is reasonable if:

  • ARM images are unavailable or unstable for this version
  • The team prioritizes consistency over performance for dev environments

Recommendation

LGTM

This is a safe, reasonable change for local development. The benefits of consistency outweigh the minor performance cost on ARM machines.

Optional enhancement: Consider adding a comment in the docker-compose.yml explaining why this platform constraint exists, for future maintainers:

clamav:
  image: clamav/clamav:1.2.3-47
  platform: linux/amd64  # Force AMD64 for consistency across architectures
  networks: [pycon_net]
  restart: unless-stopped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant