Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SummaryThis PR adds an explicit platform specification ( ReviewArchitecture & Design ✅Approved - This is a minimal, targeted change that addresses a specific compatibility issue.
Why This Change MattersAdding
ConsiderationsPerformance trade-off: On ARM machines (Apple Silicon), this forces emulation via Rosetta/QEMU, which can be slower than native ARM images. However, for a background service like ClamAV that's used for file scanning, this trade-off is reasonable if:
RecommendationLGTM ✅ This is a safe, reasonable change for local development. The benefits of consistency outweigh the minor performance cost on ARM machines. Optional enhancement: Consider adding a comment in the docker-compose.yml explaining why this platform constraint exists, for future maintainers: clamav:
image: clamav/clamav:1.2.3-47
platform: linux/amd64 # Force AMD64 for consistency across architectures
networks: [pycon_net]
restart: unless-stopped |
No description provided.