Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jan 15, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, just a few smaller remarks below.
Comment on lines
+1
to
+6
| ephem.tests.* | ||
| ephem.stars.k | ||
| ephem.stars.v | ||
| ephem._libastro.Observer.__init__ | ||
| ephem.FixedBody.__init__ | ||
| ephem._libastro.FixedBody.__init__ |
Collaborator
There was a problem hiding this comment.
Could you add comments to group and explain these entries? Probably something like this:
# Tests
ephem.tests.*
# Leaked loop variables
ephem.stars.k
ephem.stars.v
# ?
ephem._libastro.Observer.__init__
ephem.FixedBody.__init__
ephem._libastro.FixedBody.__init__
|
|
||
| from . import _libastro | ||
|
|
||
| __version__: str |
Collaborator
There was a problem hiding this comment.
Constants should be marked as Final:
Suggested change
| __version__: str | |
| __version__: Final[str] |
(Also applies to all the constants below.)
Comment on lines
+14
to
+15
| STAR_NUMBER_NAME: dict[int, str] | ||
| STAR_NAME_NUMBER: dict[str, int] |
Collaborator
There was a problem hiding this comment.
Should probably be Final, too.
Contributor
Author
|
Thanks for your feedback. All remarks should be resolved now. |
srittau
approved these changes
Jan 15, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial type stubs for the ephem library (PyPI:
pyephem).ephemis a widely used library for high-precision astronomy calculations. Since it is largely implemented in C, static analysis tools currently have difficulty providing completions and type safety for it.The stubs provide comprehensive coverage for the publicly accessible API, including:
__init__)_libastroC-extension interfacecitiesandstarsdatabases