Add __format__ overrides to complex, float, int, and str#14523
Merged
brianschubert merged 1 commit intopython:mainfrom Aug 5, 2025
Merged
Add __format__ overrides to complex, float, int, and str#14523brianschubert merged 1 commit intopython:mainfrom
__format__ overrides to complex, float, int, and str#14523brianschubert merged 1 commit intopython:mainfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
(for context, this was discovered as a common source of errors when running stubtest with python/mypy#19593) |
AlexWaygood
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These four builtins each define their own
__format__methods at runtime. While they all have the same signature asobject.__format__, explicit overrides are needed so that type checkers resolve the right overrides in the presence of multiple inheritance.Currently, type checkers incorrectly accept this code:
In particular, this affects
enum.IntEnum/enum.StrEnumsubclasses, which useint.__format__/str.__format__at runtime, but type checkers think they useenum.Enum.__format__(which, unlike the builtin__format__methods, accepts keyword arguments).