gh-145685: per-type method cache implementation#150160
Open
kumaraditya303 wants to merge 25 commits into
Open
Conversation
kumaraditya303
requested review from
a team,
AA-Turner,
FFY00,
ZeroIntensity,
emmatyping,
ericsnowcurrently,
erlend-aasland and
markshannon
as code owners
kumaraditya303
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 728021c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150160%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
colesbury
reviewed
Jun 1, 2026
zooba
reviewed
Jun 5, 2026
colesbury
reviewed
Jun 15, 2026
colesbury
left a comment
colesbury
left a comment
Contributor
There was a problem hiding this comment.
A few more comments below (mostly found by Claude). Also:
- Have you run single-threaded benchmarks to ensure that we haven't introduced any regressions with this?
- Does the
type_lookupbenchmark scale as well as the other scaling benchmarks? In other words, should we consider this a partial or full fix for the type cache scaling issues?
| new_size = old_size * 2; | ||
| } | ||
| if (new_size > _Py_TYPECACHE_MAXSIZE) { | ||
| // The new size is too big, don't resize and just return. |
Contributor
There was a problem hiding this comment.
Maybe we should add a RARE_EVENT_STAT_INC or OBJECT_STAT_INC for this condition?
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyType_Lookup/_PyType_LookupStackRefAndVersion#145685