Skip to content

gh-143429: Use compile-time NaN encoding detection for test_struct #143432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Jan 9, 2026
Merged

gh-143429: Use compile-time NaN encoding detection for test_struct #143432

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0bbf71e
Skip NaN encoding assertions for MIPS
chenx97 Jan 5, 2026
fbe2091
Remove redundant comments
chenx97 Jan 5, 2026
f5bddb5
Use the unversioned gcc doc link
chenx97 Jan 5, 2026
6674a76
Use compile-time NaN encoding detection for test_struct
chenx97 Jan 7, 2026
13ab453
Remove unused imports
chenx97 Jan 7, 2026
376c04d
Move nan flag to Modules/_testcapi/float.c and use bool
chenx97 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Lib/test/test_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,10 +942,15 @@ def test_half_float(self):
else:
expected = 0x7e

packed = struct.pack('<e', math.nan)
self.assertEqual(packed[1] & 0x7e, expected)
packed = struct.pack('<e', -math.nan)
self.assertEqual(packed[1] & 0x7e, expected)
# Skip NaN encoding checks for MIPS because `math.nan` changes its value
# depending on toolchain settings. See:
# https://en.wikipedia.org/wiki/NaN#Encoding
Comment thread
skirpichev marked this conversation as resolved.
Outdated
# https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/MIPS-Options.html#index-mnan_003d2008
Comment thread
skirpichev marked this conversation as resolved.
Outdated
if not platform.machine().startswith('mips'):
packed = struct.pack('<e', math.nan)
self.assertEqual(packed[1] & 0x7e, expected)
packed = struct.pack('<e', -math.nan)
self.assertEqual(packed[1] & 0x7e, expected)

# Checks for round-to-even behavior
format_bits_float__rounding_list = [
Expand Down
Loading