-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-143249: Fix buffer leak when overlapped operation fails to start (OS-Windows) #143250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyongtao-code
wants to merge
8
commits into
python:main
Choose a base branch
from
hyongtao-code:fix-mem-leak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−3
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0ebd149
Fix buffer leak when overlapped operation fails to start (OS-Windows)
hyongtao-code c523c11
📜🤖 Added by blurb_it.
blurb-it[bot] 2508cfb
📜🤖 Added by blurb_it.
blurb-it[bot] b1a0ace
Revert "📜🤖 Added by blurb_it."
hyongtao-code 2ac1a80
Add test case
hyongtao-code 9b5c1c0
Construct a test case suitable for running with -R.
hyongtao-code 9ae6017
Update NEW.s
hyongtao-code d69f8e5
Apply suggestion from @picnixz
hyongtao-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2025-12-28-14-41-02.gh-issue-143249.K4vEp4.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix possible buffer leaks in Windows overlapped I/O on error handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1806,7 +1806,7 @@ _overlapped_Overlapped_WSASendTo_impl(OverlappedObject *self, HANDLE handle, | |
| case ERROR_IO_PENDING: | ||
| Py_RETURN_NONE; | ||
| default: | ||
| self->type = TYPE_NOT_STARTED; | ||
| Overlapped_clear(self); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was very confused with this, I thought it was |
||
| return SetFromWindowsErr(err); | ||
| } | ||
| } | ||
|
|
@@ -1873,7 +1873,7 @@ _overlapped_Overlapped_WSARecvFrom_impl(OverlappedObject *self, | |
| case ERROR_IO_PENDING: | ||
| Py_RETURN_NONE; | ||
| default: | ||
| self->type = TYPE_NOT_STARTED; | ||
| Overlapped_clear(self); | ||
| return SetFromWindowsErr(err); | ||
| } | ||
| } | ||
|
|
@@ -1940,7 +1940,7 @@ _overlapped_Overlapped_WSARecvFromInto_impl(OverlappedObject *self, | |
| case ERROR_IO_PENDING: | ||
| Py_RETURN_NONE; | ||
| default: | ||
| self->type = TYPE_NOT_STARTED; | ||
| Overlapped_clear(self); | ||
| return SetFromWindowsErr(err); | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.