-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-143241: Fix infinite loop in zoneinfo._common.load_data #143243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Please add a NEWS entry, users will be glad to know that that bug was fixed.
I would not call it a DoS.
Misc/NEWS.d/next/Library/2025-12-28-12-38-53.gh-issue-143241.yW250u.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Remove unnecessary tz_bytes variable. Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Misc/NEWS.d/next/Library/2025-12-28-13-49-06.gh-issue-143241.5H4b8d.rst
Outdated
Show resolved
Hide resolved
…H4b8d.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
I'm going to wait for the CI to be green and then I'll merge. |
|
Thanks @fatihhcelik for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ythonGH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…ythonGH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-143251 is a backport of this pull request to the 3.14 branch. |
|
GH-143252 is a backport of this pull request to the 3.13 branch. |
…H-143243) (#143252) gh-143241: Fix infinite loop in `zoneinfo._common.load_data` (GH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…H-143243) (#143251) gh-143241: Fix infinite loop in `zoneinfo._common.load_data` (GH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
zoneinfo._common.load_data#143241