Skip to content

Conversation

@raven-dev-ops
Copy link

@raven-dev-ops raven-dev-ops commented Dec 28, 2025

Summary

  • Add free-threading regression coverage for binascii (Audit all built-in modules for thread safety #116738).
  • Assert that importing binascii does not enable the GIL when running with -X gil=0.
  • Add a multi-thread stress test for common binascii operations under -X gil=0.

Motivation

  • Built-in extension modules should be thread-safe in free-threaded builds and correctly declare their GIL usage.

Testing

  • Default build: ./python -m test -j0 test_binascii
  • Free-threaded build: ./python -X gil=0 -m test -j0 test_binascii

Issue

@python-cla-bot
Copy link

python-cla-bot bot commented Dec 28, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Dec 28, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 28, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@raven-dev-ops raven-dev-ops force-pushed the gh-116738-binascii-audit branch from bffc02c to ce6d55a Compare December 28, 2025 00:28
@bedevere-app
Copy link

bedevere-app bot commented Dec 28, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@raven-dev-ops raven-dev-ops changed the title gh-116738: add free-threading tests for binascii gh-116738: Add free-threading tests for binascii Dec 28, 2025
@raven-dev-ops raven-dev-ops deleted the gh-116738-binascii-audit branch December 28, 2025 00:37
@raven-dev-ops raven-dev-ops restored the gh-116738-binascii-audit branch December 28, 2025 01:02
@raven-dev-ops raven-dev-ops reopened this Dec 28, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 28, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@raven-dev-ops raven-dev-ops marked this pull request as draft December 28, 2025 02:10
@raven-dev-ops
Copy link
Author

raven-dev-ops commented Dec 28, 2025

This is the first time I have tried to contribute to an open-source project, just let me know what I am doing wrong, I am thankful for your time.

@raven-dev-ops raven-dev-ops marked this pull request as ready for review December 28, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant