Skip to content

gh-142207: remove assertions incompatible under profiling.sampling #142331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihong0618 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

gh-142207: remove assertions incompatible under profiling.sampling #142331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ade0ef8
fix: close issue #142207 by drop the assert
yihong0618 Dec 6, 2025
82b16d8
fix: make news format right
yihong0618 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-12-06-13-19-43.gh-issue-142207.x_X9oH.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix: profiling.sampling may cause assertion ``!(has_gil &&
gil_requested)``
6 changes: 2 additions & 4 deletions Modules/_remote_debugging/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@

// Check GIL status
int has_gil = 0;
int gil_requested = 0;

Check warning on line 318 in Modules/_remote_debugging/threads.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

variable ‘gil_requested’ set but not used [-Wunused-but-set-variable]

Check warning on line 318 in Modules/_remote_debugging/threads.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

variable ‘gil_requested’ set but not used [-Wunused-but-set-variable]
#ifdef Py_GIL_DISABLED
int active = GET_MEMBER(_thread_status, ts, unwinder->debug_offsets.thread_state.status).active;
has_gil = active;
Expand All @@ -335,12 +335,10 @@
#endif
if (has_gil) {
status_flags |= THREAD_STATUS_HAS_GIL;
// gh-142207 for remote debugging.
gil_requested = 0;
}

// Assert that we never have both HAS_GIL and GIL_REQUESTED set at the same time
// This would indicate a race condition in the GIL state tracking
assert(!(has_gil && gil_requested));

// Check CPU status
long pthread_id = GET_MEMBER(long, ts, unwinder->debug_offsets.thread_state.thread_id);

Expand Down
Loading